refactor: dispose whole supabase client on hot-restart

Author: Vinzent03

packages/supabase/lib/src/supabase_client.dart

@@ -268,6 +268,7 @@ class SupabaseClient {
 
   Future<void> dispose() async {
     _log.fine('Dispose SupabaseClient');
+    await realtime.disconnect();
     await _authStateSubscription?.cancel();
     await _isolate.dispose();
     _authInstance?.dispose();

…utter/lib/src/realtime_cleanup_stub.dart …er/lib/src/hot_restart_cleanup_stub.dartpackages/supabase_flutter/lib/src/realtime_cleanup_stub.dart renamed to packages/supabase_flutter/lib/src/hot_restart_cleanup_stub.dart packages/supabase_flutter/lib/src/realtime_cleanup_stub.dart renamed to packages/supabase_flutter/lib/src/hot_restart_cleanup_stub.dart

@@ -1,5 +1,5 @@
 import 'package:supabase_flutter/supabase_flutter.dart';
 
-void markRealtimeClientToBeDisconnected(RealtimeClient client) {}
+void markRealtimeClientToBeDisconnected(SupabaseClient client) {}
 
 void disconnectPreviousRealtimeClient() {}

…lutter/lib/src/realtime_cleanup_web.dart …ter/lib/src/hot_restart_cleanup_web.dartpackages/supabase_flutter/lib/src/realtime_cleanup_web.dart renamed to packages/supabase_flutter/lib/src/hot_restart_cleanup_web.dart packages/supabase_flutter/lib/src/realtime_cleanup_web.dart renamed to packages/supabase_flutter/lib/src/hot_restart_cleanup_web.dart

@@ -5,25 +5,26 @@ import 'package:supabase_flutter/supabase_flutter.dart';
 @JS()
 external JSFunction? supabaseFlutterWSToClose;
 
-/// Store a function to properly disconnect the previous [RealtimeClient] in
+/// Store a function to properly dispose the previous [SupabaseClient] in
 /// the js context.
 ///
-/// WebSocket connections are not closed when Flutter is hot-restarted on web.
+/// WebSocket connections and [BroadcastChannel] are not closed when Flutter is hot-restarted on web.
 ///
-/// This causes old dart code that is still associated with the WebSocket
-/// connection to be still running and causes unexpected behavior like type
+/// This causes old dart code that is still associated with those
+/// connections to be still running and causes unexpected behavior like type
 /// errors and the fact that the events of the old connection may still be
 /// logged.
-void markRealtimeClientToBeDisconnected(RealtimeClient client) {
+void markRealtimeClientToBeDisconnected(SupabaseClient client) {
   void disconnect() {
-    client.disconnect(
+    client.realtime.disconnect(
         code: 1000, reason: 'Closed due to Flutter Web hot-restart');
+    client.dispose();
   }
 
   supabaseFlutterWSToClose = disconnect.toJS;
 }
 
-/// Disconnect the previous [RealtimeClient] if it exists.
+/// Disconnect the previous [SupabaseClient] if it exists.
 ///
 /// This is done by calling the function stored by
 /// [markRealtimeClientToBeDisconnected] from the js context

packages/supabase_flutter/lib/src/supabase.dart

@@ -11,8 +11,8 @@ import 'package:supabase_flutter/src/flutter_go_true_client_options.dart';
 import 'package:supabase_flutter/src/local_storage.dart';
 import 'package:supabase_flutter/src/supabase_auth.dart';
 
-import 'realtime_cleanup_stub.dart'
-    if (dart.library.js_interop) 'realtime_cleanup_web.dart';
+import 'hot_restart_cleanup_stub.dart'
+    if (dart.library.js_interop) 'hot_restart_cleanup_web.dart';
 
 import 'version.dart';
 
@@ -211,7 +211,7 @@ class Supabase with WidgetsBindingObserver {
     // flutter web hot-restart.
     if (kDebugMode) {
       disconnectPreviousRealtimeClient();
-      markRealtimeClientToBeDisconnected(client.realtime);
+      markRealtimeClientToBeDisconnected(client);
     }
     _widgetsBindingInstance?.addObserver(this);
     _initialized = true;