Logo is wrong

[supakeen]

At some point it seems the custom logo handler stopped working. Write a test and fix.

[TehPeGaSuS]

Looking forward to have this option available

[supakeen]

@PeGaSuS-Coder It's interesting because it seems to work (sometimes), for example it works for the https://bpa.st/ and https://paste.pythondiscord.com/ instances. I'll take another look when I find the time on what's causing this but that's why it wasn't high on my list.

[wookie184]

It works for paste.pythondiscord.com because we override the default image in the /static directory rather than using the logo_path parameter https://github.com/python-discord/infra/blob/fab77edceea9328e2eeab164d1df6d061b20c238/kubernetes/namespaces/default/pinnwand/deployment.yaml#L44-L46. I'd guess maybe bpaste is doing something similar?

I think the issue that makes logo_path not work is that the static_path parameter here

pinnwand/src/pinnwand/http.py

Line 86 in 3c866b4

static_path=path.static,

causes the application to look in the /static folder (so it finds the default image) before looking through the routes, so the route that would look up the image using the logo_path is never reached

pinnwand/src/pinnwand/http.py

Lines 57 to 69 in 3c866b4

	if configuration.logo_path:
	pages += [
	(
	r"/static/logo.png",
	handler.website.Logo,
	{"path": configuration.logo_path},
	),
	(
	r"/static/favicon.png",
	handler.website.Logo,
	{"path": configuration.logo_path},
	),
	]

[TehPeGaSuS]

On https://bpa.st/ I see the blue bunny (default logo) and not any custom image.