Fix consume ratelimit config

[wookie184]

Configuration for rate limits lets you set the consume rate:

pinnwand/src/pinnwand/configuration.py

Lines 12 to 26 in e737aba

	ratelimit = {
	"read": {
	"capacity": 100,
	"consume": 1,
	"refill": 2,
	},
	"create": {
	"capacity": 2,
	"consume": 2,
	"refill": 1,
	},
	"delete": {
	"capacity": 2,
	"consume": 2,
	"refill": 1,

However, this configuration is not used, instead the consume value is always 1:

pinnwand/src/pinnwand/defensive.py

Line 46 in e737aba

if not ratelimit_area[area][address].consume(1):

[shtlrs]

I've also noticed that the Limiter.consume method takes a key and num_tokens argument.
https://github.com/falconry/token-bucket/blob/4d94f6418e4f1d6dfc641e854aa5ec85b7e0c735/token_bucket/storage.py#L126-L127

This means that we could simplify the defensive.ratelimit_area dictionary to simply map the areas to a Limiter instance, and use the request's ip address as the key which will identify the right consumption bucket. And the num_tokens param will be passed the configuration's consumption value

What do you guys think of implementing this along with the bug fix ?

[wookie184]

Oh, interesting. So in the current .consume(1), 1 is the key rather than the number of items consumed, that is a bit confusing.

Using the IP as the key seems like a nicer option, yeah.