[SDESK-7942]: Item sent to Personal space still available in the Sent Desk Output stage (#5192) (#5210)

* SDESK-7942: hide personal items from sent desk output

* suggested fixes

Author: BrianMwangi21

scripts/apps/monitoring/services/CardsService.ts

@@ -141,7 +141,10 @@ export function CardsService(search, session, desks) {
             case SENT_OUTPUT:
                 deskId = card._id.substring(0, card._id.indexOf(':'));
                 query.filter({bool: {
-                    filter: {term: {'task.desk_history': deskId}},
+                    must: [
+                        {term: {'task.desk_history': deskId}},
+                        {exists: {field: 'task.desk'}},
+                    ],
                     must_not: {term: {'task.desk': deskId}},
                 }});
                 break;

scripts/apps/monitoring/tests/monitoring.spec.ts

@@ -185,6 +185,19 @@ describe('monitoring', () => {
             });
         }));
 
+        it('can get criteria for sent desk output', inject((cards, session) => {
+            var card: any = {_id: '1:sent', type: 'sentDeskOutput'};
+            var criteria = cards.criteria(card);
+
+            expect(criteria.source.query.filtered.filter.and).toContain({bool: {
+                must: [
+                    {term: {'task.desk_history': '1'}},
+                    {exists: {field: 'task.desk'}},
+                ],
+                must_not: {term: {'task.desk': '1'}},
+            }});
+        }));
+
         it('can get criteria for highlight', inject((cards, session) => {
             var card = {type: 'highlights'};
             var queryParam = {highlight: '123'};