Skip to content

Commit 3e0626d

Browse files
committed
disable antithesis assertion for number of changes
Signed-off-by: Somtochi Onyekwere <[email protected]>
1 parent a8eda4a commit 3e0626d

File tree

1 file changed

+8
-6
lines changed
  • crates/corro-agent/src/agent

1 file changed

+8
-6
lines changed

crates/corro-agent/src/agent/util.rs

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1276,12 +1276,14 @@ pub fn process_complete_version<T: Deref<Target = rusqlite::Connection> + Commit
12761276

12771277
debug!(%actor_id, %version, "complete change, applying right away! seqs: {seqs:?}, last_seq: {last_seq}, changes len: {len}, db version: {version}");
12781278

1279-
let details = json!({"len": len, "seqs": seqs.start_int(), "seqs_end": seqs.end_int(), "actor_id": actor_id, "version": version});
1280-
assert_always!(
1281-
len <= seqs.len(),
1282-
"number of changes is equal to the seq len",
1283-
&details
1284-
);
1279+
// TODO: Figure out a better assertion. This assertion is disabled for now to reduce false negatives. We can receive a valid complete changeset
1280+
// where the number of changes is less than the seqs range because some rows have been overridden by a newer update.
1281+
// let details = json!({"len": len, "seqs": seqs.start_int(), "seqs_end": seqs.end_int(), "actor_id": actor_id, "version": version});
1282+
// assert_always!(
1283+
// len <= seqs.len(),
1284+
// "number of changes is equal to the seq len",
1285+
// &details
1286+
// );
12851287
debug_assert!(len <= seqs.len(), "change from actor {actor_id} version {version} has len {len} but seqs range is {seqs:?} and last_seq is {last_seq}");
12861288

12871289
// Insert all the changes in a single statement

0 commit comments

Comments
 (0)