Fix TestFlyDeployHAPlacement to assert success explicitly

The test was failing with 'Condition never satisfied' even when the deploy
succeeded. The issue was that EventuallyWithT expects the function to call
an assertion. When the deploy succeeded on the first try, we didn't call
any assertions, so EventuallyWithT timed out waiting for a success signal.

Fix: Add assert.True(c, true) when deploy succeeds so EventuallyWithT
knows the condition was satisfied.

Author: mattp-fly

test/preflight/fly_deploy_test.go

@@ -108,6 +108,9 @@ func TestFlyDeployHAPlacement(t *testing.T) {
 				t.Logf("Deploy failed with unexpected error (will not retry): %s", stderr)
 				assert.Fail(c, fmt.Sprintf("deploy failed with unexpected error: %s", stderr))
 			}
+		} else {
+			// Explicitly assert success so EventuallyWithT knows we passed
+			assert.True(c, true, "deploy succeeded")
 		}
 	}, 30*time.Second, 5*time.Second, "deploy should succeed after Corrosion replication, last error: %s", lastError)