Skip to content

Commit a9d85ff

Browse files
authored
deploy: skip regional IPs in DNS check (#4560)
Regional IPs aren't returned by our public DNS, so the check always fails for apps with regional IPs. Make sure we only count global IPs here.
1 parent 1e235cb commit a9d85ff

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

internal/command/deploy/machines_deploymachinesapp.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1382,9 +1382,9 @@ func (md *machineDeployment) checkDNS(ctx context.Context) error {
13821382

13831383
var numIPv4, numIPv6 int
13841384
for _, ipAddr := range ipAddrs {
1385-
if ipAddr.Type == "v4" || ipAddr.Type == "shared_v4" {
1385+
if (ipAddr.Type == "v4" && ipAddr.Region == "global") || ipAddr.Type == "shared_v4" {
13861386
numIPv4 += 1
1387-
} else if ipAddr.Type == "v6" {
1387+
} else if ipAddr.Type == "v6" && ipAddr.Region == "global" {
13881388
numIPv6 += 1
13891389
}
13901390
}

0 commit comments

Comments
 (0)