Make preview deployment wait for CI to complete

Change preview workflow to trigger on workflow_run after CI completes
instead of running in parallel. This ensures the generated CLI docs
are committed before the preview build runs.

Co-Authored-By: Claude Opus 4.5 <[email protected]>

Author: kylemclaren

.github/workflows/fly-preview.yml

@@ -1,8 +1,11 @@
 name: Preview Deployment
 
 on:
+  workflow_run:
+    workflows: ["CI"]
+    types: [completed]
   pull_request:
-    types: [opened, reopened, synchronize, closed]
+    types: [closed]
 
 env:
   FLY_API_TOKEN: ${{ secrets.FLY_PREVIEW_API_TOKEN }}
@@ -16,10 +19,13 @@ permissions:
 jobs:
   preview:
     runs-on: ubuntu-latest
+    if: >
+      (github.event_name == 'workflow_run' && github.event.workflow_run.conclusion == 'success') ||
+      (github.event_name == 'pull_request' && github.event.action == 'closed')
     outputs:
       url: ${{ steps.deploy.outputs.url }}
     concurrency:
-      group: pr-${{ github.event.number }}
+      group: pr-${{ github.event.pull_request.number || github.event.workflow_run.pull_requests[0].number }}
 
     environment:
       name: preview
@@ -29,6 +35,7 @@ jobs:
       - name: Checkout
         uses: actions/checkout@v4
         with:
+          ref: ${{ github.event.workflow_run.head_sha || github.event.pull_request.head.sha }}
           fetch-depth: 0
 
       - name: Deploy preview app
@@ -40,20 +47,25 @@ jobs:
           memory: 256
 
       - name: Comment on PR
-        if: github.event.action != 'closed'
+        if: github.event_name == 'workflow_run'
         continue-on-error: true
         uses: actions/github-script@v7
         with:
           script: |
             const url = '${{ steps.deploy.outputs.url }}';
-            const sha = context.sha.substring(0, 7);
+            const prNumber = ${{ github.event.workflow_run.pull_requests[0].number || 0 }};
+            if (!prNumber) {
+              console.log('No PR number found, skipping comment');
+              return;
+            }
+            const sha = '${{ github.event.workflow_run.head_sha }}'.substring(0, 7);
             const body = `### Preview Deployment\n\n| Name | URL |\n|------|-----|\n| Preview | ${url} |\n\nCommit: \`${sha}\``;
 
             // Find existing comment
             const { data: comments } = await github.rest.issues.listComments({
               owner: context.repo.owner,
               repo: context.repo.repo,
-              issue_number: context.issue.number,
+              issue_number: prNumber,
             });
             const existing = comments.find(c => c.body.includes('### Preview Deployment'));
 
@@ -68,7 +80,7 @@ jobs:
               await github.rest.issues.createComment({
                 owner: context.repo.owner,
                 repo: context.repo.repo,
-                issue_number: context.issue.number,
+                issue_number: prNumber,
                 body,
               });
             }
@@ -77,7 +89,7 @@ jobs:
     name: E2E Tests
     runs-on: ubuntu-latest
     needs: preview
-    if: github.event.action != 'closed'
+    if: github.event_name == 'workflow_run'
     continue-on-error: true
 
     steps:
@@ -144,14 +156,19 @@ jobs:
         uses: actions/github-script@v7
         with:
           script: |
+            const prNumber = ${{ github.event.workflow_run.pull_requests[0].number || 0 }};
+            if (!prNumber) {
+              console.log('No PR number found, skipping comment');
+              return;
+            }
             const status = '${{ job.status }}';
             const emoji = status === 'success' ? '✅' : '❌';
             const body = `### E2E Test Results\n\n${emoji} Tests ${status}\n\nRan against: ${{ needs.preview.outputs.url }}`;
 
             const { data: comments } = await github.rest.issues.listComments({
               owner: context.repo.owner,
               repo: context.repo.repo,
-              issue_number: context.issue.number,
+              issue_number: prNumber,
             });
             const existing = comments.find(c => c.body.includes('### E2E Test Results'));
 
@@ -166,7 +183,7 @@ jobs:
               await github.rest.issues.createComment({
                 owner: context.repo.owner,
                 repo: context.repo.repo,
-                issue_number: context.issue.number,
+                issue_number: prNumber,
                 body,
               });
             }
@@ -175,7 +192,7 @@ jobs:
     name: Lighthouse CI
     runs-on: ubuntu-latest
     needs: preview
-    if: github.event.action != 'closed'
+    if: github.event_name == 'workflow_run'
     continue-on-error: true
 
     steps:
@@ -201,10 +218,15 @@ jobs:
         uses: actions/github-script@v7
         with:
           script: |
+            const prNumber = ${{ github.event.workflow_run.pull_requests[0].number || 0 }};
+            if (!prNumber) {
+              core.setOutput('urls', '${{ needs.preview.outputs.url }}');
+              return;
+            }
             const { data: files } = await github.rest.pulls.listFiles({
               owner: context.repo.owner,
               repo: context.repo.repo,
-              pull_number: context.issue.number,
+              pull_number: prNumber,
             });
 
             const baseUrl = '${{ needs.preview.outputs.url }}';
@@ -243,6 +265,11 @@ jobs:
         uses: actions/github-script@v7
         with:
           script: |
+            const prNumber = ${{ github.event.workflow_run.pull_requests[0].number || 0 }};
+            if (!prNumber) {
+              console.log('No PR number found, skipping comment');
+              return;
+            }
             const manifest = ${{ steps.lighthouse.outputs.manifest }};
             const links = ${{ steps.lighthouse.outputs.links }};
 
@@ -269,7 +296,7 @@ jobs:
             const { data: comments } = await github.rest.issues.listComments({
               owner: context.repo.owner,
               repo: context.repo.repo,
-              issue_number: context.issue.number,
+              issue_number: prNumber,
             });
             const existing = comments.find(c => c.body.includes('### Lighthouse Results'));
 
@@ -284,7 +311,7 @@ jobs:
               await github.rest.issues.createComment({
                 owner: context.repo.owner,
                 repo: context.repo.repo,
-                issue_number: context.issue.number,
+                issue_number: prNumber,
                 body,
               });
             }