Skip to content

Commit 9375f79

Browse files
Address review feedback: drop dead rowScrubPreview reset, fix stale keyDown comment
1 parent dd411f0 commit 9375f79

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

Pika/Views/EditableColorValue.swift

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -498,7 +498,6 @@ struct EditableColorValue: View {
498498
isInvalid = false
499499
preEditColor = nil
500500
sessionOwner = nil
501-
rowScrubPreview = nil
502501
// Only clear the own-write marker when we're about to resync anyway. A `resync: false`
503502
// commit (see `finishEditing`'s success path) deliberately keeps `values` as typed rather
504503
// than the freshly (and possibly lossily) decomposed colour — clearing this unconditionally

Pika/Views/ScrubTextField.swift

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -422,7 +422,8 @@ final class ScrubTextField: NSTextField {
422422
switch next.type {
423423
case .keyDown:
424424
// Escape abandons the scrub. Only meaningful once a drag is actually under way;
425-
// otherwise let the key fall through to its normal handling.
425+
// otherwise the key is dropped rather than dispatched (narrow window: only
426+
// while the mouse button is held on this field).
426427
guard didBeginDrag, next.keyCode == 53 else { continue }
427428
cancelDrag()
428429
return

0 commit comments

Comments
 (0)