Address PR review feedback from #200

Fix swap undo consistency, context menu labels, index clamping,
filename sanitization, compliance icon differentiation, unused import,
and migration guard.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: superhighfives

Pika/AppDelegate.swift

@@ -133,7 +133,18 @@ class AppDelegate: NSObject, NSApplicationDelegate {
         let existing = Defaults[.colorHistory]
         guard !existing.isEmpty else { return }
         let history = Palette(id: UUID(), name: nil, pairs: existing, createdAt: Date())
-        Defaults[.palettes] = [history]
+        var palettes = Defaults[.palettes]
+        if palettes.isEmpty {
+            palettes = [history]
+        } else {
+            palettes[0] = Palette(
+                id: palettes[0].id,
+                name: palettes[0].name,
+                pairs: existing + palettes[0].pairs,
+                createdAt: palettes[0].createdAt
+            )
+        }
+        Defaults[.palettes] = palettes
         Defaults[.colorHistory] = []
     }
 

Pika/Services/Exporter.swift

@@ -1,4 +1,3 @@
-import Defaults
 import Foundation
 
 class Exporter {

Pika/Services/Eyedroppers.swift

@@ -79,12 +79,11 @@ class Eyedroppers: ObservableObject {
     }
 
     func swap() {
-        pushUndo()
+        let paletteIndex = Defaults[.activePaletteIndex]
+        if paletteIndex == 0 { pushUndo() }
         let temp = foreground.color
         foreground.color = background.color
         background.color = temp
-
-        let paletteIndex = Defaults[.activePaletteIndex]
         var palettes = Defaults[.palettes]
         guard paletteIndex >= 0, paletteIndex < palettes.count else { return }
 

Pika/Views/ColorHistoryDrawer.swift

@@ -9,6 +9,7 @@ struct ColorHistoryChip: View {
     let onApplyBackground: () -> Void
     let onRemove: () -> Void
     let onClearAll: (() -> Void)?
+    var isAutoHistory: Bool = true
 
     @State private var isHovered = false
 
@@ -40,7 +41,7 @@ struct ColorHistoryChip: View {
                 Button(PikaText.textHistoryApplyForeground, action: onApplyForeground)
                 Button(PikaText.textHistoryApplyBackground, action: onApplyBackground)
                 Divider()
-                Button(PikaText.textHistoryRemove, action: onRemove)
+                Button(isAutoHistory ? PikaText.textHistoryRemove : PikaText.textPaletteRemoveChip, action: onRemove)
                 if let onClearAll = onClearAll {
                     Button(PikaText.textHistoryClear, action: onClearAll)
                 }
@@ -217,12 +218,15 @@ struct ColorHistoryDrawer: View {
 
     private var activePalette: Palette? {
         let idx = activePaletteIndex
-        guard idx >= 0, idx < palettes.count else { return palettes.first }
+        guard idx >= 0, idx < palettes.count else {
+            DispatchQueue.main.async { activePaletteIndex = 0 }
+            return palettes.first
+        }
         return palettes[idx]
     }
 
     private var isAutoHistory: Bool {
-        activePaletteIndex == 0
+        activePalette?.isAutoHistory ?? false
     }
 
     var body: some View {
@@ -241,7 +245,8 @@ struct ColorHistoryDrawer: View {
                                 onApplyForeground: { applyForeground(pair) },
                                 onApplyBackground: { applyBackground(pair) },
                                 onRemove: { removePair(pair) },
-                                onClearAll: isAutoHistory ? { isShowingClearConfirm = true } : nil
+                                onClearAll: isAutoHistory ? { isShowingClearConfirm = true } : nil,
+                                isAutoHistory: isAutoHistory
                             )
                             .transition(.opacity)
                             .animation(

Pika/Views/ContentView.swift

@@ -140,16 +140,24 @@ struct ContentView: View {
             guard let palette = palette else { return }
 
             let json = Exporter.paletteToJSON(pairs: palette.pairs, name: palette.name)
+            let invalidChars = CharacterSet(charactersIn: "/:\\")
             let fileName = (palette.name ?? "color-history")
                 .lowercased()
                 .replacingOccurrences(of: " ", with: "-")
+                .components(separatedBy: invalidChars)
+                .joined()
 
             let savePanel = NSSavePanel()
             savePanel.allowedContentTypes = [.json]
             savePanel.nameFieldStringValue = "\(fileName).json"
             savePanel.isExtensionHidden = false
             if savePanel.runModal() == .OK, let url = savePanel.url {
-                try? json.write(to: url, atomically: true, encoding: .utf8)
+                do {
+                    try json.write(to: url, atomically: true, encoding: .utf8)
+                } catch {
+                    let alert = NSAlert(error: error)
+                    alert.runModal()
+                }
             }
         }
     }

Pika/Views/NavigationMenu.swift

@@ -42,7 +42,7 @@ struct NavigationMenu: View {
             Button(action: {
                 NSApp.sendAction(#selector(AppDelegate.triggerToggleCompliance), to: nil, from: nil)
             }, label: {
-                IconImage(name: showCompliance ? "checkmark.shield" : "checkmark.shield")
+                IconImage(name: showCompliance ? "checkmark.shield.fill" : "checkmark.shield")
             })
             .buttonStyle(PlainButtonStyle())
             .padding(.horizontal, 6.0)