Skip to content

Translate new 1.9.0 window-shadow strings - #243

Merged
superhighfives merged 4 commits into
1.9.0from
i18n/1.9.0-strings
Jul 20, 2026
Merged

Translate new 1.9.0 window-shadow strings#243
superhighfives merged 4 commits into
1.9.0from
i18n/1.9.0-strings

Conversation

@superhighfives

Copy link
Copy Markdown
Owner

The new UI strings added in 1.9.0 (Window Settings section, shadow dropdown, and the "Expand to fit" control) shipped as English fallbacks in the non-English locales. This translates them across all eight locales, matching each locale's existing phrasing (e.g. reusing the established "… while picking" / "Settings" wording from keys like preferences.pick.hide).

Keys translated in de, es, fr, hr, ja, pl, zh-Hans, zh-Hant:

  • preferences.window.title — "Window Settings"
  • preferences.shadow.description — "Window shadow"
  • preferences.shadow.options.always — "Show shadow"
  • preferences.shadow.options.hiddenWhilePicking — "Hide shadow while picking"
  • preferences.shadow.options.never — "Hide shadow"
  • content.expandToFit — "Expand to fit"

All eight .strings files pass plutil -lint.

Note: these are best-effort translations — worth a native-speaker pass before the stable 1.9.0, particularly the "Expand to fit" control wording and the Traditional Chinese window term (used 視窗). Targets 1.9.0 so it rides along to main with #241.

🤖 Generated with Claude Code

Replace the English fallbacks for the new Window Settings / shadow /
expand-to-fit keys with translations across all eight locales, matching
each locale's existing 'hide … while picking' and settings phrasing.
@claude

claude Bot commented Jul 19, 2026

Copy link
Copy Markdown

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

Drop the 'ratio'/'value'/'text' modifiers from color.ratio, color.lc, and
color.apca.body so the footer stays compact, mirroring the English change
(Contrast / Contrast (Lc) / Body). Locales where the body term is already a
single compact word (de, ja, zh) are left as-is.
@superhighfives

Copy link
Copy Markdown
Owner Author

@claude Review please.

1 similar comment
@superhighfives

Copy link
Copy Markdown
Owner Author

@claude Review please.

Repository owner deleted a comment from claude Bot Jul 20, 2026
@claude

claude Bot commented Jul 20, 2026

Copy link
Copy Markdown

Claude encountered an error after 2s —— View job


I'll analyze this and get back to you.

Repository owner deleted a comment from claude Bot Jul 20, 2026
Rapid-fire @claude comments spawned concurrent claude.yml runs that raced
on context assembly, yielding an empty formatted_context and an immediate
is_error failure. Add a per-issue/PR concurrency group (no cancel — each
request is distinct and worth completing).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@superhighfives

Copy link
Copy Markdown
Owner Author

@claude Review please.

@claude

claude Bot commented Jul 20, 2026

Copy link
Copy Markdown

Claude encountered an error after 3s —— View job


I'll analyze this and get back to you.

@superhighfives

Copy link
Copy Markdown
Owner Author

@claude Review please.

@claude

claude Bot commented Jul 20, 2026

Copy link
Copy Markdown

Claude encountered an error after 2s —— View job


I'll analyze this and get back to you.

Tag-mode runs were failing with an opaque is_error and no detail, because
the full run output wasn't shown. Enable show_full_output (as the reusable
review workflow already does) so the actual first-request API error is
visible in the log. Note: issue_comment workflows run from the default
branch, so this only takes effect once merged to main.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@superhighfives

Copy link
Copy Markdown
Owner Author

@claude Review please.

@claude

claude Bot commented Jul 20, 2026

Copy link
Copy Markdown

Claude encountered an error after 2s —— View job


I'll analyze this and get back to you.

@superhighfives

Copy link
Copy Markdown
Owner Author

@claude Review please.

@claude

claude Bot commented Jul 20, 2026

Copy link
Copy Markdown

Claude finished @superhighfives's task in 2m 14s —— View job


Review

  • Gather context (diff, CLAUDE.md, changed files)
  • Review translations across all 8 locale files
  • Validate .strings syntax
  • Post review feedback

No issues found. This diff (vs origin/1.9.0) covers three things: the window-shadow/expandToFit translations described in the PR body, the earlier "shorten contrast labels" pass, and two @claude workflow reliability tweaks — all look correct.

Translations (de, es, fr, hr, ja, pl, zh-Hans, zh-Hant)

  • All six new keys (preferences.window.title, preferences.shadow.description, preferences.shadow.options.{always,hiddenWhilePicking,never}, content.expandToFit) are translated in every locale, with no leftover English fallbacks.
  • Verified each locale's hiddenWhilePicking string reuses the same "…while picking" phrasing/word order as the existing preferences.pick.hide, exactly as the PR description claims (e.g. es: "Ocultar Pika durante la selección" / "Ocultar sombra durante la selección").
  • zh-Hant's preferences.window.title = "視窗設置" correctly matches the file's dominant "設置" pattern for settings titles (常規設置, 選擇設置, 應用設置), and 視窗 (vs. the one outlier 窗口 at preferences.float.description) matches the majority existing usage (help.url.group.window, menubarPopover, splash, etc.) — so the author's self-flagged "used 視窗" note is a reasonable choice, not a new inconsistency.
  • color.ratio/color.lc shortening is applied only where the existing translation was multi-word (matching English "Contrast"/"Contrast (Lc)"); locales that were already short (ja, zh-Hans, zh-Hant) were correctly left alone.
  • Spot-checked quoting/escaping and key ordering — all entries are well-formed ("key" = "value";), diffs are minimal and scoped to just the intended lines.
  • Note: I wasn't able to run plutil -lint in this sandbox (the command required elevated approval that isn't available to me here) — the PR description states all eight files already pass plutil -lint, and manual inspection didn't turn up any unterminated strings, mismatched quotes, or stray characters.

Workflow changes (.github/workflows/claude.yml)

  • Adding concurrency: { group: claude-<issue/pr#>, cancel-in-progress: false } and show_full_output: true are sensible, well-commented reliability fixes given the repeated "Claude encountered an error" runs visible in this PR's own comment history — serializing prevents the concurrent-context race, and full output should surface the actual API error next time instead of an opaque failure.

Nothing blocking. As the author already noted, a native-speaker pass on "Expand to fit" wording (currently fairly literal per-locale, e.g. ja "広げて表示") before stable 1.9.0 would still be worthwhile, but that's a follow-up, not a defect in this PR.

@superhighfives
superhighfives merged commit 36c504e into 1.9.0 Jul 20, 2026
2 checks passed
@superhighfives
superhighfives deleted the i18n/1.9.0-strings branch July 20, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant