Translate new 1.9.0 window-shadow strings - #243
Conversation
Replace the English fallbacks for the new Window Settings / shadow / expand-to-fit keys with translations across all eight locales, matching each locale's existing 'hide … while picking' and settings phrasing.
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Drop the 'ratio'/'value'/'text' modifiers from color.ratio, color.lc, and color.apca.body so the footer stays compact, mirroring the English change (Contrast / Contrast (Lc) / Body). Locales where the body term is already a single compact word (de, ja, zh) are left as-is.
|
@claude Review please. |
1 similar comment
|
@claude Review please. |
|
Claude encountered an error after 2s —— View job I'll analyze this and get back to you. |
Rapid-fire @claude comments spawned concurrent claude.yml runs that raced on context assembly, yielding an empty formatted_context and an immediate is_error failure. Add a per-issue/PR concurrency group (no cancel — each request is distinct and worth completing). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
@claude Review please. |
|
Claude encountered an error after 3s —— View job I'll analyze this and get back to you. |
|
@claude Review please. |
|
Claude encountered an error after 2s —— View job I'll analyze this and get back to you. |
Tag-mode runs were failing with an opaque is_error and no detail, because the full run output wasn't shown. Enable show_full_output (as the reusable review workflow already does) so the actual first-request API error is visible in the log. Note: issue_comment workflows run from the default branch, so this only takes effect once merged to main. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
@claude Review please. |
|
Claude encountered an error after 2s —— View job I'll analyze this and get back to you. |
|
@claude Review please. |
|
Claude finished @superhighfives's task in 2m 14s —— View job Review
No issues found. This diff (vs Translations (
Workflow changes (
Nothing blocking. As the author already noted, a native-speaker pass on "Expand to fit" wording (currently fairly literal per-locale, e.g. |
The new UI strings added in 1.9.0 (Window Settings section, shadow dropdown, and the "Expand to fit" control) shipped as English fallbacks in the non-English locales. This translates them across all eight locales, matching each locale's existing phrasing (e.g. reusing the established "… while picking" / "Settings" wording from keys like
preferences.pick.hide).Keys translated in
de,es,fr,hr,ja,pl,zh-Hans,zh-Hant:preferences.window.title— "Window Settings"preferences.shadow.description— "Window shadow"preferences.shadow.options.always— "Show shadow"preferences.shadow.options.hiddenWhilePicking— "Hide shadow while picking"preferences.shadow.options.never— "Hide shadow"content.expandToFit— "Expand to fit"All eight
.stringsfiles passplutil -lint.Note: these are best-effort translations — worth a native-speaker pass before the stable 1.9.0, particularly the "Expand to fit" control wording and the Traditional Chinese window term (used 視窗). Targets
1.9.0so it rides along tomainwith #241.🤖 Generated with Claude Code