Modernize for macOS 14 + preserve Touch Bar copy icon tinting

[superhighfives]

Summary

Builds on the macOS 14 modernization work from #242 and addresses the review feedback flagged there.

Changes

Remove dead pre-macOS-11 SF Symbol fallback icons
IconImage used to fall back to hand-drawn SVG copies of SF Symbols on macOS < 11. With the deployment target at macOS 14, IconImage always uses Image(systemName:), leaving Assets.xcassets/Icons/ as dead fallback assets. Deletes the unused imagesets and updates the Touch Bar copy button to load doc.on.doc from SF Symbols directly.

Modernize deprecated SwiftUI modifiers for macOS 14

• .foregroundColor(_:) → .foregroundStyle(_:)
• .cornerRadius(_:) → .clipShape(.rect(cornerRadius:))
• .edgesIgnoringSafeArea(.all) → .ignoresSafeArea()
• .accentColor(_:) → .tint(_:)

Preserve Touch Bar copy icon tinting (review fix)
The deleted doc.on.doc asset set template-rendering-intent: template, which let AppKit auto-tint the Touch Bar copy glyph to match the dark background. NSImage(systemSymbolName:accessibilityDescription:) does not guarantee isTemplate on macOS, so the replacement now sets isTemplate = true explicitly to keep the icon adapting as before.

Test plan

• Build both the Pika and Pika (Mac App Store) targets in Xcode
• Confirm no remaining deprecation warnings for the migrated modifiers
• Visually verify the Touch Bar copy button still tints correctly in light/dark contexts

🤖 Generated with Claude Code

---

Generated by Claude Code

[superhighfives]

@claude Review please.

[superhighfives]

Code Review

Reviewed the full diff — the macOS 14 modifier migration plus the Touch Bar fix. No correctness issues found. This is a clean, mechanical modernization and the risky spots are all handled correctly.

.foregroundColor → .foregroundStyle — every ternary site is type-consistent. Crucially, wherever accentColor appears both branches are explicitly prefixed with Color. (required, since ShapeStyle has no static .accentColor — a bare .accentColor wouldn't compile):

• ColorHistoryDrawer.swift, HelpView.swift, NavigationMenu.swift — all Color.accentColor : Color.X.
• Footer.swift isCompliant ? Color.primary : Color.secondary.opacity(0.5) — the opaque-.opacity case is safe because both branches are explicitly Color.
• Remaining bare ternaries (.primary : .secondary, .black : .white) infer to the same concrete type cleanly.

.cornerRadius → .clipShape(.rect(cornerRadius:)) — KeyboardShortcutKey, Toast, TouchBarVisual. Behaviourally equivalent (the old .cornerRadius is itself an antialiased rounded-rect clip), all applied to views, no clipping-order regression.

.edgesIgnoringSafeArea(.all) → .ignoresSafeArea() — the 4 WindowCoordinator sites are all-region hosting roots; .ignoresSafeArea() defaults to all regions/edges, so equivalent.

.accentColor → .tint — SplashView, equivalent at that site.

Touch Bar isTemplate = true — correct. NSImage(systemSymbolName: "doc.on.doc", ...) is a valid symbol (force-unwrap safe), and setting isTemplate preserves the tinting the deleted template asset provided. (Symbol images are generally template by default on macOS, so it's belt-and-suspenders — but it matches the old asset's declared template-rendering-intent and guarantees the behaviour regardless.)

Deleted assets — verified genuinely dead: IconImage only uses Image(systemName:), no Image("…") catalog references remain, and the only asset-catalog NSImage(named:) pointing at a deleted icon was the one converted to systemSymbolName. No dangling references, no half-migrated sites.

Note: the claude-review check failed as an infra artefact — it declines/errors on claude/* head branches (the exact issue #244 addresses), not a defect in this diff. The Unit Tests check is the meaningful gate.

🤖 Generated with Claude Code

---

Generated by Claude Code