Harden installed vision diagnostics

Author: supermang617

app/camera-state.js

@@ -0,0 +1,29 @@
+export function cameraErrorMessage(error) {
+  const name = String(error?.name || "").trim();
+  const message = String(error?.message || error || "").trim();
+  const normalized = `${name} ${message}`.toLowerCase();
+
+  if (
+    name === "NotFoundError" ||
+    normalized.includes("requested device not found") ||
+    normalized.includes("device not found") ||
+    normalized.includes("no camera")
+  ) {
+    return "No camera device was found. Connect or enable a camera, then try again.";
+  }
+
+  if (
+    name === "NotAllowedError" ||
+    name === "SecurityError" ||
+    normalized.includes("permission denied") ||
+    normalized.includes("not allowed")
+  ) {
+    return "Camera permission was denied. Allow camera access for Iris, then try again.";
+  }
+
+  if (name === "NotReadableError" || normalized.includes("could not start video source")) {
+    return "The camera is already in use or unavailable. Close other camera apps, then try again.";
+  }
+
+  return message || "Camera snapshot failed.";
+}

app/camera-state.test.mjs

@@ -0,0 +1,28 @@
+import assert from "node:assert/strict";
+import { test } from "node:test";
+import { cameraErrorMessage } from "./camera-state.js";
+
+test("camera errors show no-camera guidance instead of raw DOM exceptions", () => {
+  assert.equal(
+    cameraErrorMessage(new DOMException("Requested device not found", "NotFoundError")),
+    "No camera device was found. Connect or enable a camera, then try again."
+  );
+});
+
+test("camera permission errors show permission recovery guidance", () => {
+  assert.equal(
+    cameraErrorMessage(new DOMException("Permission denied", "NotAllowedError")),
+    "Camera permission was denied. Allow camera access for Iris, then try again."
+  );
+});
+
+test("busy camera errors show close-other-apps guidance", () => {
+  assert.equal(
+    cameraErrorMessage(new DOMException("Could not start video source", "NotReadableError")),
+    "The camera is already in use or unavailable. Close other camera apps, then try again."
+  );
+});
+
+test("unknown camera errors preserve useful details", () => {
+  assert.equal(cameraErrorMessage(new Error("Camera driver crashed.")), "Camera driver crashed.");
+});

app/main.js

@@ -11,6 +11,7 @@ import {
 } from "./attachment-state.js";
 import { requireTrustedBlobUrl } from "./attachment-url.js";
 import { latestBrowserPreview } from "./browser-preview.js";
+import { cameraErrorMessage } from "./camera-state.js";
 import {
   formatDynamicContextStatus,
   parseDynamicContextCommand
@@ -442,6 +443,9 @@ async function submitScreenAreaMessage() {
   if (thinking || speaking) {
     return;
   }
+  await cancelActiveAsr();
+  wakeCommandArmed = false;
+  voiceLoop = false;
   const latencyTrace = new VoiceLatencyTrace();
   const prompt = elements.hudInput.value.trim() || defaultScreenPrompt;
   const turnStarted = performance.now();
@@ -457,6 +461,9 @@ async function submitScreenAreaMessage() {
     elements.hudOutput.textContent = response.text;
     rememberTurn("user", `[screen] ${prompt}`);
     rememberTurn("iris", response.text);
+    if (response.diagnostic_path) {
+      logVoice("screen_probe_diagnostic", response.diagnostic_path);
+    }
     logVoice(
       "screen_probe_complete",
       `model_ms=${response.model_elapsed_ms}; total_ms=${Math.round(performance.now() - turnStarted)}`
@@ -1506,7 +1513,9 @@ elements.visionButton.addEventListener("click", () => {
     return;
   }
   lookWithCamera().catch((error) => {
-    elements.hudOutput.textContent = String(error);
+    logVoice("camera_snapshot_error", String(error));
+    elements.hudOutput.textContent = cameraErrorMessage(error);
+    restartListeningIfReady();
   });
 });
 
@@ -1657,6 +1666,9 @@ async function readDocumentAttachment(file) {
 
 async function lookWithCamera() {
   const prompt = elements.hudInput.value.trim() || defaultCameraPrompt;
+  await cancelActiveAsr();
+  wakeCommandArmed = false;
+  voiceLoop = false;
   await captureCameraSnapshot();
   elements.hudInput.value = "";
   resizeComposerInput();
@@ -1681,10 +1693,9 @@ async function captureCameraSnapshot() {
         frameRate: { ideal: 5, max: 10 }
       }
     });
-    setImageAttachment(
-      await snapshotFromStream(stream),
-      "Camera snapshot attached. Type what you want Iris to inspect."
-    );
+    const snapshot = await snapshotFromStream(stream);
+    await saveCameraSnapshotDiagnostic(snapshot);
+    setImageAttachment(snapshot, "Camera snapshot captured. Thinking locally...");
   } finally {
     if (stream) {
       for (const track of stream.getTracks()) {
@@ -1725,11 +1736,30 @@ async function snapshotFromStream(stream) {
   return {
     name: "camera-snapshot.jpg",
     bytes: Array.from(new Uint8Array(buffer)),
+    width,
+    height,
     previewUrl: createTrustedAttachmentObjectUrl(blob),
     kindLabel: "Camera"
   };
 }
 
+async function saveCameraSnapshotDiagnostic(snapshot) {
+  try {
+    const diagnostic = await call("save_camera_snapshot_diagnostic", {
+      imageBytes: snapshot.bytes,
+      width: snapshot.width,
+      height: snapshot.height
+    });
+    const imagePath = diagnostic.imagePath || diagnostic.image_path || "";
+    logVoice(
+      "camera_snapshot_diagnostic",
+      `bytes=${snapshot.bytes.length}; width=${snapshot.width}; height=${snapshot.height}; path=${imagePath}`
+    );
+  } catch (error) {
+    logVoice("camera_snapshot_diagnostic_error", String(error));
+  }
+}
+
 async function snapshotFromVideoFile(file) {
   validateVideoSize(file);
   const video = document.createElement("video");