What is the purpose of following code? #267
Unanswered
pavolkacej
asked this question in
Q&A
Replies: 2 comments
-
Beta Was this translation helpful? Give feedback.
0 replies
-
|
Yeah I agree that this could be made easier to read. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
https://github.com/suragnair/alpha-zero-general/blob/master/Coach.py#L69
Shouldn't it be better to simplify the operation to multiple lines? This way it is really hard to read. I understand
x[0], x[2], but what about thatr * ...? What does the computed value do, and how should this computation work?I know this oneliners may be fast, but I suggest it is better to do something following
Using multiple lines would make it so much easier to follow. If code works, that is great, but please think about other people, that will have to read it in the future.
Beta Was this translation helpful? Give feedback.
All reactions