Turn off edge presets (#621)

* Turn off edge presets in Cubase

Since cubase calls setState and then setCurrentProgram on restore
if you have presets and modify one and save a project, edge presets
are not really viable.

* Respond to review

* Always off

Author: baconpaul

src/PluginProcessor.cpp

@@ -49,6 +49,19 @@ ObxfAudioProcessor::ObxfAudioProcessor()
 
     isHostAutomatedChange = true;
 
+    if (juce::PluginHostType().isCubase() || juce::PluginHostType().isNuendo() ||
+        juce::PluginHostType().isSteinberg())
+    {
+        // see KVR thread. Cubase sends a setProgram not only when user selects but also after a
+        // state restore. https://www.kvraudio.com/forum/viewtopic.php?p=9220240#p9220240
+        supportEdgePrograms = false;
+    }
+    else
+    {
+        // Make a decision to just not bother. Too many funky host edge cases
+        supportEdgePrograms = false;
+    }
+
     initializeCallbacks();
 
     juce::PropertiesFile::Options options;
@@ -216,10 +229,16 @@ bool ObxfAudioProcessor::producesMidi() const
 bool ObxfAudioProcessor::isMidiEffect() const { return false; }
 double ObxfAudioProcessor::getTailLengthSeconds() const { return 0.0; }
 
-int ObxfAudioProcessor::getNumPrograms() { return utils->lastFactoryPatch + 1; }
-int ObxfAudioProcessor::getCurrentProgram() { return currentDawProgram; }
+int ObxfAudioProcessor::getNumPrograms()
+{
+    return supportEdgePrograms ? utils->lastFactoryPatch + 1 : 1;
+}
+int ObxfAudioProcessor::getCurrentProgram() { return supportEdgePrograms ? currentDawProgram : 0; }
 void ObxfAudioProcessor::setCurrentProgram(const int index)
 {
+    if (!supportEdgePrograms)
+        return;
+
     if (index < 0 || index > utils->lastFactoryPatch + 1 ||
         (size_t)index > utils->patchesAsLinearList.size() + 1)
         return;

src/PluginProcessor.h

@@ -78,6 +78,7 @@ class ObxfAudioProcessor final : public juce::AudioProcessor,
     void changeProgramName(int index, const juce::String &newName) override {};
     int currentDawProgram{0}; // doesn't change for non-factory
     int lastLoadedProgram{0}; // always the index of last utils fxp loaded
+    bool supportEdgePrograms{true};
     Utils::PatchTreeNode::weakptr_t lastLoadedPatchNode;
 
     void resetLastLoadedProgramTo(int idx);