Phaser param mismatch

[baconpaul]

Run code at head and load a phaser and you will see

----- 10 Waveform `Waveform'
Metadata Mismatch (fx=Phaser attr=Maximum Values): param[10]='Waveform'; param metadata value=6 surge value=5 /Users/paul/dev/music/surge/src/common/dsp/effects/SurgeSSTFXAdapter.h:249

which is what happens when the internal param type mismatches the param metadata in the set-effects version of the phaser.

Investigate before 1.4

[baconpaul]

Ahh this is an absolute blocker for the 1.4 release and a real bug

On 12/25 @Andreya-Autumn in set-effects set phaser up like this

 .withUnorderedMapFormatting({
                    {0, "Sine"},
                    {1, "Triangle"},
                    {2, "Ramp"},
                    {3, "Saw"},
                    {4, "Square"},
                    {5, "Noise"},
                    {6, "Sample & Hold"},
                })

and wrote a remap streaming item which short circuit calls. Fine. Parameter.cpp says this

 switch (i)
            {
            case 0:
                txt = "Sine";
                break;
            case 1:
                txt = "Triangle";
                break;
            case 2:
                txt = "Sawtooth";
                break;
            case 3:
                txt = "Noise";
                break;
            case 4:
                txt = "Sample & Hold";
                break;
            case 5:
                txt = "Square";
                break;
            }

but the surge fx adapter doesn't call the remap function - we never hooked it up.

So every phaser waveform will be wrong basically.

The solution is, I think

1. Realize that phaser version went 1->2
2. So update the surge streaming version 34-35 or what not
3. and gif there's a phaser in the unstream from 34 call the remapper

but there may be a different way to hook it in.

Critically the sst-effect version is I believe not streamed in the surge versioned patch.

So a bit tricky.