Skip to content

Commit d1845f5

Browse files
committed
clippy fixes
1 parent 54109a7 commit d1845f5

3 files changed

Lines changed: 12 additions & 16 deletions

File tree

revision-derive/src/ast/attributes.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ impl<O: AttributeOptions> Parse for FilteredAttributes<O> {
128128

129129
let parsed_options =
130130
attr.parse_args_with(Punctuated::<O::Option, Token![,]>::parse_terminated)?;
131-
options.extend(parsed_options.into_iter())
131+
options.extend(parsed_options)
132132
}
133133

134134
let options = O::finish(Span::call_site(), options)?;

src/implementations/range.rs

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@ mod tests {
7171
}
7272

7373
#[test]
74+
#[allow(clippy::reversed_empty_ranges)]
7475
fn test_range_inverted() {
7576
let val = 100u32..10u32;
7677
let mut mem: Vec<u8> = vec![];
@@ -186,17 +187,15 @@ mod tests {
186187
let mut mem: Vec<u8> = vec![];
187188
val.serialize_revisioned(&mut mem).unwrap();
188189

189-
let truncated = &mem[..1];
190-
let result =
191-
<Range<u32> as DeserializeRevisioned>::deserialize_revisioned(&mut truncated.as_ref());
190+
let mut truncated = &mem[..1];
191+
let result = <Range<u32> as DeserializeRevisioned>::deserialize_revisioned(&mut truncated);
192192
assert!(result.is_err());
193193
}
194194

195195
#[test]
196196
fn test_range_empty_reader() {
197-
let empty: &[u8] = &[];
198-
let result =
199-
<Range<u32> as DeserializeRevisioned>::deserialize_revisioned(&mut empty.as_ref());
197+
let mut empty: &[u8] = &[];
198+
let result = <Range<u32> as DeserializeRevisioned>::deserialize_revisioned(&mut empty);
200199
assert!(result.is_err());
201200
}
202201

src/implementations/system_time.rs

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -137,17 +137,15 @@ mod tests {
137137
let mut mem: Vec<u8> = vec![];
138138
val.serialize_revisioned(&mut mem).unwrap();
139139

140-
let truncated = &mem[..2];
141-
let result =
142-
<SystemTime as DeserializeRevisioned>::deserialize_revisioned(&mut truncated.as_ref());
140+
let mut truncated = &mem[..2];
141+
let result = <SystemTime as DeserializeRevisioned>::deserialize_revisioned(&mut truncated);
143142
assert!(result.is_err());
144143
}
145144

146145
#[test]
147146
fn test_system_time_empty_reader() {
148-
let empty: &[u8] = &[];
149-
let result =
150-
<SystemTime as DeserializeRevisioned>::deserialize_revisioned(&mut empty.as_ref());
147+
let mut empty: &[u8] = &[];
148+
let result = <SystemTime as DeserializeRevisioned>::deserialize_revisioned(&mut empty);
151149
assert!(result.is_err());
152150
}
153151

@@ -212,9 +210,8 @@ mod tests {
212210
let mut mem: Vec<u8> = vec![];
213211
val.serialize_revisioned(&mut mem).unwrap();
214212

215-
let secs_only = &mem[..mem.len() - 1];
216-
let result =
217-
<SystemTime as DeserializeRevisioned>::deserialize_revisioned(&mut secs_only.as_ref());
213+
let mut secs_only = &mem[..mem.len() - 1];
214+
let result = <SystemTime as DeserializeRevisioned>::deserialize_revisioned(&mut secs_only);
218215
assert!(result.is_err());
219216
}
220217
}

0 commit comments

Comments
 (0)