Skip to content

Commit b0bb9d1

Browse files
committed
ci: drop redundant spectron build from test path
Spectron tests now resolve the package from source via the root tsconfig paths mapping, so building the dist/ bundle beforehand is no longer needed to run them. Remove the build:spectron prefix from the test:spectron script and drop the build-spectron dependency + artifact download from the test-spectron CI job. The build-spectron job itself is retained because the typecheck job still validates the bundled dist/spectron.d.ts.
1 parent 563b47d commit b0bb9d1

2 files changed

Lines changed: 1 addition & 8 deletions

File tree

.github/workflows/check.yml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -385,7 +385,6 @@ jobs:
385385

386386
test-spectron:
387387
name: Test Spectron
388-
needs: build-spectron
389388
runs-on: ubuntu-latest
390389
steps:
391390
- name: Install Bun
@@ -399,12 +398,6 @@ jobs:
399398
- name: Install dependencies
400399
run: bun install
401400

402-
- name: Download Spectron build
403-
uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4.3.0
404-
with:
405-
name: spectron-build
406-
path: packages/spectron/dist/
407-
408401
- name: Run Spectron tests
409402
run: cd packages/tests/spectron && bun test --reporter=junit --reporter-outfile=junit.xml
410403

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
"test": "bun run build:sdk && cd packages/tests/surrealdb && bun test --preload ./global.ts",
1717
"test:wasm": "bun run build:sdk && bun run build:wasm && cd packages/tests/surrealdb && SURREAL_BACKEND=wasm bun test --preload ./global-wasm.ts",
1818
"test:node": "bun run build:sdk && bun run build:node && cd packages/tests/surrealdb && SURREAL_BACKEND=node bun test --preload ./global-node.ts",
19-
"test:spectron": "bun run build:spectron && cd packages/tests/spectron && bun test",
19+
"test:spectron": "cd packages/tests/spectron && bun test",
2020
"sync": "turbo sync",
2121
"deploy:sdk": "turbo deploy --filter surrealdb --",
2222
"deploy:sqon": "turbo deploy --filter @surrealdb/sqon --",

0 commit comments

Comments
 (0)