-
Notifications
You must be signed in to change notification settings - Fork 214
Open
Labels
kind/featureNew feature or requestNew feature or request
Description
What would you like to be added?
We should consider dropping the sampling rate to EXPERIMENTAL_BPF_SAMPLE_RATE: 1000
We have seen decent improvement from the CPU utilization side when reducing the sampling rate.
Risk - We have not quantified the possible loss of granularity of the power data when enabling this, however when comparing to our redfish raw data it is still very close.
Why is this needed?
CPU usage reduction.
dave-tucker
Metadata
Metadata
Assignees
Labels
kind/featureNew feature or requestNew feature or request
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
dave-tucker commentedon Jun 18, 2024
We'll need to retest on
main
since #1481 has changed what's done before the sampling check in the eBPF code vs. what was done in the last released version. There might not be an appreciable difference in probe execution time with/without sampling set. I'll set up some micro-benchmarks to confirm once #1438 has gone in since that's blocking easier benchmarking/testing of the eBPF code.[-][ref] default bpf sample rate [/-][+][rfe] default bpf sample rate [/+]dave-tucker commentedon Jul 11, 2024
Related to #1611 and #1607