Skip to content

[rfe] default bpf sample rate  #1553

@jtaleric

Description

@jtaleric

What would you like to be added?

We should consider dropping the sampling rate to EXPERIMENTAL_BPF_SAMPLE_RATE: 1000

We have seen decent improvement from the CPU utilization side when reducing the sampling rate.

Risk - We have not quantified the possible loss of granularity of the power data when enabling this, however when comparing to our redfish raw data it is still very close.
image

Why is this needed?

CPU usage reduction.

Activity

dave-tucker

dave-tucker commented on Jun 18, 2024

@dave-tucker
Collaborator

We'll need to retest on main since #1481 has changed what's done before the sampling check in the eBPF code vs. what was done in the last released version. There might not be an appreciable difference in probe execution time with/without sampling set. I'll set up some micro-benchmarks to confirm once #1438 has gone in since that's blocking easier benchmarking/testing of the eBPF code.

changed the title [-][ref] default bpf sample rate [/-] [+][rfe] default bpf sample rate [/+] on Jun 18, 2024
dave-tucker

dave-tucker commented on Jul 11, 2024

@dave-tucker
Collaborator

Related to #1611 and #1607

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @dave-tucker@jtaleric

        Issue actions

          [rfe] default bpf sample rate · Issue #1553 · sustainable-computing-io/kepler