Skip to content

Commit 17e10ff

Browse files
chore: remove unused rar tooling from CI [AI-assisted] (#1020)
The codebase no longer extracts RAR archives, so CI should not install or validate unrar/unar/7zip binaries. Keeping only git as an explicit system dependency reduces CI setup overhead and removes misleading platform checks. Also removes the unused algerian_ministry_rar_filename config field to keep configuration aligned with ZIP-based processing. Co-authored-by: florath-ai-assistant[bot] <Andreas.Florath@telekom.de>
1 parent 4b10972 commit 17e10ff

File tree

2 files changed

+5
-25
lines changed

2 files changed

+5
-25
lines changed

.github/workflows/ci.yml

Lines changed: 5 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -272,22 +272,19 @@ jobs:
272272
if: matrix.os == 'ubuntu-latest'
273273
run: |
274274
sudo apt-get update
275-
sudo apt-get install -y unrar git curl
275+
sudo apt-get install -y git
276276
277277
- name: Install system dependencies (macOS)
278278
if: matrix.os == 'macos-latest'
279279
run: |
280-
# Install unar (macOS equivalent of unrar)
281-
brew install unar || echo "RAR tools installation failed"
282-
# git and curl are pre-installed on macOS
280+
# git is pre-installed on GitHub Actions macOS runners
281+
git --version
283282
284283
- name: Install system dependencies (Windows)
285284
if: matrix.os == 'windows-latest'
286285
run: |
287-
# Install via chocolatey (available on GitHub Actions Windows runners)
288-
choco install unrar -y || echo "unrar installation failed, trying 7zip"
289-
choco install 7zip -y || echo "7zip installation failed"
290286
# git is pre-installed on GitHub Actions Windows runners
287+
git --version
291288
292289
- name: Setup Unicode encoding for Windows
293290
if: matrix.os == 'windows-latest'
@@ -408,20 +405,6 @@ jobs:
408405
return False
409406
410407
commands = ['python', 'git']
411-
# Check for RAR tools on non-Windows platforms
412-
if '${{ matrix.os }}' == 'macos-latest':
413-
# Try both unar and unrar on macOS
414-
for cmd in ['unar', 'unrar']:
415-
try:
416-
subprocess.run([cmd, '--help'], capture_output=True, timeout=10)
417-
commands.append(cmd)
418-
print(f'[INFO] Using {cmd} for RAR support on macOS')
419-
break
420-
except:
421-
continue
422-
elif '${{ matrix.os }}' == 'ubuntu-latest':
423-
commands.append('unrar')
424-
425408
all_good = all(check_command(cmd) for cmd in commands)
426409
status = 'PASSED' if all_good else 'PARTIAL'
427410
print(f'Platform validation: {status}')
@@ -486,4 +469,4 @@ jobs:
486469
if: ${{ needs.ruff-lint.result == 'failure' || needs.mypy-check.result == 'failure' || needs.custom-checks.result == 'failure' || needs.test.result == 'failure' || needs.security-scan.result == 'failure' || needs.build.result == 'failure' || needs.cross-platform-integration.result == 'failure' || needs.performance-tests.result == 'failure' }}
487470
run: |
488471
echo "❌ Some checks failed!"
489-
exit 1
472+
exit 1

src/aletheia_probe/config.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,9 +73,6 @@ class DataSourceUrlConfig(BaseModel):
7373
"https://dgrsdt.dz/storage/revus/",
7474
description="Base URL for Algerian Ministry data",
7575
)
76-
algerian_ministry_rar_filename: str = Field(
77-
"revues.rar", description="RAR filename for Algerian Ministry data"
78-
)
7976
retraction_watch_repo_url: str = Field(
8077
"https://gitlab.com/crossref/retraction-watch-data.git",
8178
description="Git repository URL for Retraction Watch data",

0 commit comments

Comments
 (0)