Skip to content

Commit 8576934

Browse files
authored
Enable cross-platform integration tests on pull requests [AI-assisted] (#17)
Fixes #15 Update the cross-platform-integration job to run on pull requests in addition to pushes to main branch. This allows catching platform- specific issues (Windows/macOS/Linux) before merging to main. Changes: - Modified workflow condition from: if: github.event_name == 'push' && github.ref == 'refs/heads/main' - To: if: | (github.event_name == 'push' && github.ref == 'refs/heads/main') || github.event_name == 'pull_request' Benefits: - Catch platform-specific bugs before merging - Higher confidence in code quality across all supported platforms - Cleaner main branch history with fewer post-merge fixes Tradeoffs: - Increased CI time for PRs (~10-15 minutes) - Higher CI resource usage per PR
1 parent a91ce53 commit 8576934

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

.github/workflows/ci.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,9 @@ jobs:
191191
name: Cross-Platform Integration Tests
192192
runs-on: ${{ matrix.os }}
193193
needs: [lint-and-type-check, test]
194-
if: github.event_name == 'push' && github.ref == 'refs/heads/main'
194+
if: |
195+
(github.event_name == 'push' && github.ref == 'refs/heads/main') ||
196+
github.event_name == 'pull_request'
195197
strategy:
196198
matrix:
197199
os: [ubuntu-latest, windows-latest, macos-latest]

0 commit comments

Comments
 (0)