Prevented minor memory leak in STPrivilegedTask, silenced static analyzer complaints

Author: sveinbjornt

Application/EditorController.m

@@ -54,7 +54,7 @@ - (instancetype)init {
 
 - (void)awakeFromNib {
     NSNumber *userFontSizeNum = [DEFAULTS objectForKey:DefaultsKey_EditorFontSize];
-    CGFloat fontSize = userFontSizeNum ? [userFontSizeNum floatValue] : DEFAULT_TEXT_FONT_SIZE;
+    CGFloat fontSize = userFontSizeNum != nil ? [userFontSizeNum floatValue] : DEFAULT_TEXT_FONT_SIZE;
     NSFont *font = [NSFont fontWithName:DEFAULT_TEXT_FONT_NAME size:fontSize];
     [textView setFont:font];
     [textView setAutomaticQuoteSubstitutionEnabled:NO];

Application/Resources/Platypus-Info.plist

@@ -445,7 +445,7 @@
 	<key>CFBundleSignature</key>
 	<string>????</string>
 	<key>CFBundleVersion</key>
-	<string>1331</string>
+	<string>1332</string>
 	<key>LSApplicationCategoryType</key>
 	<string>public.app-category.developer-tools</string>
 	<key>LSMinimumSystemVersion</key>

ScriptExec/SEController.m

@@ -284,14 +284,14 @@ - (void)loadAppSettings {
 
         // Font and size
         NSNumber *userFontSizeNum = [DEFAULTS objectForKey:ScriptExecDefaultsKey_UserFontSize];
-        CGFloat fontSize = userFontSizeNum ? [userFontSizeNum floatValue] : [appSettings[AppSpecKey_TextSize] floatValue];
+        CGFloat fontSize = userFontSizeNum != nil ? [userFontSizeNum floatValue] : [appSettings[AppSpecKey_TextSize] floatValue];
         fontSize = fontSize != 0 ? fontSize : DEFAULT_TEXT_FONT_SIZE;
 
         if (appSettings[AppSpecKey_TextFont]) {
             textFont = [NSFont fontWithName:appSettings[AppSpecKey_TextFont] size:fontSize];
         }
         if (textFont == nil) {
-            textFont = [NSFont fontWithName:DEFAULT_TEXT_FONT_NAME size:DEFAULT_TEXT_FONT_SIZE];
+            textFont = [NSFont fontWithName:DEFAULT_TEXT_FONT_NAME size:fontSize];
         }
 
         BOOL darkMode = NO;

Shared/STPrivilegedTask.m

@@ -31,6 +31,7 @@
 #import <stdio.h>
 #import <unistd.h>
 #import <dlfcn.h>
+#import <sys/param.h>
 
 // New error code denoting that AuthorizationExecuteWithPrivileges no longer exists
 OSStatus const errAuthorizationFnNoLongerExists = -70001;
@@ -217,7 +218,8 @@ - (OSStatus)launchWithAuthorization:(AuthorizationRef)authorization
     args[numberOfArguments] = NULL;
 
     // change to the current dir specified
-    char *prevCwd = (char *)getcwd(nil, 0);
+    char prevCwd[MAXPATHLEN];
+    getcwd(prevCwd, sizeof(prevCwd));
     chdir([self.currentDirectoryPath fileSystemRepresentation]);
 
     //use Authorization Reference to execute script with privileges