feat: add ESLint 10 support (#1472)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: ota-meshi <16508807+ota-meshi@users.noreply.github.com>
Co-authored-by: yosuke ota <otameshiyo23@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Author: 3 people

.changeset/lazy-wasps-collect.md

@@ -0,0 +1,5 @@
+---
+"eslint-plugin-svelte": minor
+---
+
+feat: add support for ESLint v10

.github/workflows/NodeCI.yml

@@ -58,8 +58,17 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest, windows-latest]
-        eslint: [8, 9]
-        node: [18.x, 20.x, 22.x, latest]
+        eslint: [8, 9, 10]
+        node: [20.x, 22.x, latest]
+        include:
+          # ESLint v9 and Node.js 18.x
+          - os: ubuntu-latest
+            eslint: 9
+            node: 18.x
+          # ESLint v8 and Node.js 18.x
+          - os: ubuntu-latest
+            eslint: 8
+            node: 18.x
     steps:
       - name: Checkout
         uses: actions/checkout@v6

packages/eslint-plugin-svelte/package.json

@@ -51,7 +51,7 @@
     "version:ci": "env-cmd -e version-ci -- pnpm run update && changeset version"
   },
   "peerDependencies": {
-    "eslint": "^8.57.1 || ^9.0.0",
+    "eslint": "^8.57.1 || ^9.0.0 || ^10.0.0",
     "svelte": "^3.37.0 || ^4.0.0 || ^5.0.0"
   },
   "peerDependenciesMeta": {

packages/eslint-plugin-svelte/src/main.ts

@@ -7,19 +7,21 @@ import prettier from './configs/flat/prettier.js';
 import all from './configs/flat/all.js';
 import * as processor from './processor/index.js';
 import * as metaModule from './meta.js';
-import type { Rule } from 'eslint';
+import type { Linter, Rule } from 'eslint';
 
+/* eslint-disable @typescript-eslint/no-unnecessary-type-assertion -- ts(2742) Error */
 export const configs = {
-	base,
-	recommended,
-	prettier,
-	all,
+	base: base as Linter.Config[],
+	recommended: recommended as Linter.Config[],
+	prettier: prettier as Linter.Config[],
+	all: all as Linter.Config[],
 	// For backward compatibility
-	'flat/base': base,
-	'flat/recommended': recommended,
-	'flat/prettier': prettier,
-	'flat/all': all
+	'flat/base': base as Linter.Config[],
+	'flat/recommended': recommended as Linter.Config[],
+	'flat/prettier': prettier as Linter.Config[],
+	'flat/all': all as Linter.Config[]
 };
+/* eslint-enable @typescript-eslint/no-unnecessary-type-assertion -- ts(2742) Error */
 
 export const rules = ruleList.reduce(
 	(obj, r) => {

packages/eslint-plugin-svelte/src/rule-types.ts

@@ -7,11 +7,12 @@
 import type { Linter } from 'eslint'
 
 declare module 'eslint' {
-  namespace Linter {
-    interface RulesRecord extends RuleOptions {}
-  }
+	interface RulesConfig extends RuleOptions {}
 }
 
+/* eslint-disable */
+/* prettier-ignore */
+
 export interface RuleOptions {
   /**
    * disallow conditionals where the type is always truthy or always falsy

packages/eslint-plugin-svelte/tools/update-rule-types.ts

@@ -6,15 +6,25 @@ void main();
 async function main() {
 	const { pluginsToRulesDTS } = await import('eslint-typegen/core');
 
-	// @ts-expect-error - types are a bit strict here
-	const ruleTypes = await pluginsToRulesDTS({ svelte: plugin });
+	const ruleTypes = await pluginsToRulesDTS(
+		{ svelte: plugin },
+		{ includeAugmentation: false, includeTypeImports: false }
+	);
 
 	void fs.writeFileSync(
 		new URL('../src/rule-types.ts', import.meta.url),
 		`// IMPORTANT!
 // This file has been automatically generated,
 // in order to update its content execute "pnpm run update"
 
+/* eslint-disable */
+/* prettier-ignore */
+import type { Linter } from 'eslint'
+
+declare module 'eslint' {
+	interface RulesConfig extends RuleOptions {}
+}
+
 ${ruleTypes}`
 	);
 }

pnpm-lock.yaml

@@ -19,6 +19,7 @@ minimumReleaseAgeExclude:
   - typescript-eslint-parser-for-extra-files
   - vite
   - zimmerframe
+  - eslint
 
 packages:
   - 'packages/*'