fix(no-navigation-without-resolve): properly detecting invalid binary expression operators (#1490)

Author: marekdedic

.changeset/shy-things-run.md

@@ -0,0 +1,5 @@
+---
+'eslint-plugin-svelte': patch
+---
+
+fix(no-navigation-without-resolve): properly detecting invalid binary expression operators

packages/eslint-plugin-svelte/src/rules/no-navigation-without-resolve.ts

@@ -384,8 +384,8 @@ function binaryExpressionIsAbsoluteUrl(
 	node: TSESTree.BinaryExpression
 ): boolean {
 	return (
-		(node.left.type !== 'PrivateIdentifier' && expressionIsAbsoluteUrl(ctx, node.left)) ||
-		expressionIsAbsoluteUrl(ctx, node.right)
+		node.operator === '+' &&
+		(expressionIsAbsoluteUrl(ctx, node.left) || expressionIsAbsoluteUrl(ctx, node.right))
 	);
 }
 
@@ -435,7 +435,7 @@ function binaryExpressionStartsWith(
 	node: TSESTree.BinaryExpression,
 	prefix: string
 ): boolean {
-	return node.left.type !== 'PrivateIdentifier' && expressionStartsWith(ctx, node.left, prefix);
+	return node.operator === '+' && expressionStartsWith(ctx, node.left, prefix);
 }
 
 function identifierStartsWith(

packages/eslint-plugin-svelte/tests/fixtures/rules/no-navigation-without-resolve/invalid/link-absolute-url-invalid-operator01-errors.yaml

@@ -0,0 +1,12 @@
+- message: Unexpected href link without resolve().
+  line: 1
+  column: 4
+  suggestions: null
+- message: Unexpected href link without resolve().
+  line: 2
+  column: 4
+  suggestions: null
+- message: Unexpected href link without resolve().
+  line: 3
+  column: 4
+  suggestions: null

packages/eslint-plugin-svelte/tests/fixtures/rules/no-navigation-without-resolve/invalid/link-absolute-url-invalid-operator01-input.svelte

@@ -0,0 +1,3 @@
+<a href={'https://example.com' - '/foo'}>Click me!</a>
+<a href={'/foo' - 'https://example.com'}>Click me!</a>
+<a href={'https://' - 'example.com'}>Click me!</a>

packages/eslint-plugin-svelte/tests/fixtures/rules/no-navigation-without-resolve/invalid/link-fragment-url-invalid-operator01-errors.yaml

@@ -0,0 +1,8 @@
+- message: Unexpected href link without resolve().
+  line: 1
+  column: 4
+  suggestions: null
+- message: Unexpected href link without resolve().
+  line: 2
+  column: 4
+  suggestions: null

packages/eslint-plugin-svelte/tests/fixtures/rules/no-navigation-without-resolve/invalid/link-fragment-url-invalid-operator01-input.svelte

@@ -0,0 +1,2 @@
+<a href={'#section' - '/foo'}>Click me!</a>
+<a href={'#section' * '/foo'}>Click me!</a>