Refactor

Author: kyoshino

src/lib/services/contents/draft/create.js

@@ -42,7 +42,9 @@ export const createProxy = ({
   getValueMap = undefined,
 }) => {
   const collection = getCollection(collectionName);
-  const collectionFile = fileName ? getCollectionFile(collectionName, fileName) : undefined;
+
+  const collectionFile =
+    collection && fileName ? getCollectionFile(collection, fileName) : undefined;
 
   if (!collection || (fileName && !collectionFile)) {
     return undefined;

src/lib/services/contents/entry/fields.js

@@ -58,7 +58,9 @@ export const getField = ({
   }
 
   const collection = getCollection(collectionName);
-  const collectionFile = fileName ? getCollectionFile(collectionName, fileName) : undefined;
+
+  const collectionFile =
+    collection && fileName ? getCollectionFile(collection, fileName) : undefined;
 
   // For entry collections, `fileName` is ignored and `collectionFile` will be `undefined`
   // Only fail if we explicitly need a file collection but can't find the file

src/lib/services/contents/file/parse.js

@@ -56,7 +56,9 @@ const detectFrontMatterFormat = (text) => {
  */
 export const parseEntryFile = async ({ text = '', path, folder: { collectionName, fileName } }) => {
   const collection = getCollection(collectionName);
-  const collectionFile = fileName ? getCollectionFile(collectionName, fileName) : undefined;
+
+  const collectionFile =
+    collection && fileName ? getCollectionFile(collection, fileName) : undefined;
 
   if (!collection) {
     throw new Error('Collection not found');

src/lib/services/contents/file/process.js

@@ -80,7 +80,9 @@ const prepareEntry = async ({ file, entries, errors }) => {
   } = file;
 
   const collection = getCollection(collectionName);
-  const collectionFile = fileName ? getCollectionFile(collectionName, fileName) : undefined;
+
+  const collectionFile =
+    collection && fileName ? getCollectionFile(collection, fileName) : undefined;
 
   if (!collection || (fileName && !collectionFile)) {
     return;