Modifying SvgElement attributes

[dee-fee]

There appears to be no simple way to change attribute values, remove an attribute, nor add an attribute for an SvgElement because its attribute collection is private and the access methods that involve the collection are either protected or internal or both. How can I do this without forking the code?

[mrbean-bremen]

This is also related to #270.
I think there is indeed no easy way to do this (I could be wrong, of course), so the fastest way is probably creating a PR that implements that....

[gvheertum]

@dee-fee If you are loading the SVG from an XML document you could consider doing the transformations on the XML before generating the SVG. I had to do this in the past (doing manipulation in a template to render chart-like output) and created a set of helper function to get specific XML elements by ID, class or other identifier (like certain attributes) and manipulate them (or remove them from the XML), before generating the SVG based on the XML.

Since the SVG is basically an XML it could be possible to add some additional functions to the library to further manipulate the XML that forms the SVG. This however might be something to think about on architectural level since exposing and allowing further manipulation is something that might affect the library in various ways.

Edit: I misread the thread a bit, I thought that manipulation was not possible at all, but there seems to be some options for manipulation.

[alexanderdibenedetto]

Any information on this? There are certain standard attributes (i.e. href) that would be very useful to modify in this model and not have to change it all over to Xml.

[H1Gdev]

What do you expect from this issue ?
Even in the current interface, adding and updating are possible from each property.
Although there is no deletion(reset to initial value).

[alexanderdibenedetto]

I realize this is years later, but it is still a very useful enhancement, as we had to workaround this using Reflection (which is NOT ideal).

Right now, the SvgElement Attributes collection is protected internal - meaning we can't update attributes in this collection. It would be very useful to do that beyond the properties exposed in SvgElement such as Color - there are other keys in SvgElement.Attributes (such as "href") that we would like to be able to modify. Instead of a new method in SvgElement for every key, I propose that the SvgElement Attributes collection be made public so that consumers of this library can modify the Attributes collection of an SVG model as they see fit.

If this proposal is accepted, I will happily take on the work of opening a PR with this change.

[mrbean-bremen]

@H1Gdev - can you comment on this?

[H1Gdev]

If we make it public, there is a possibility that we will not be able to guarantee SVG specifications.

We need to think about what functionality we want to achieve.
(I think this feature is the core of what this library provides.)

As I wrote here, it is currently not possible to delete attributes.

Right now, the SvgElement Attributes collection is protected internal - meaning we can't update attributes in this collection. It would be very useful to do that beyond the properties exposed in SvgElement such as Color - there are other keys in SvgElement.Attributes (such as "href") that we would like to be able to modify.

Values ​​set in Attributes are considered to be properties provided. (Add any that are not provided.)
Any other values ​​are set in CustomAttributes.