refs #4065 - fix 'explode' resolution for parameters

Author: frantuma

Diff for: modules/swagger-core/src/main/java/io/swagger/v3/core/util/ParameterProcessor.java

@@ -21,6 +21,7 @@
 import java.lang.annotation.Annotation;
 import java.lang.reflect.Type;
 import java.util.ArrayList;
+import java.util.Arrays;
 import java.util.LinkedHashMap;
 import java.util.List;
 import java.util.Map;
@@ -311,13 +312,14 @@ public static void setParameterExplode(Parameter parameter, io.swagger.v3.oas.an
     private static boolean isExplodable(io.swagger.v3.oas.annotations.Parameter p, Parameter parameter) {
         io.swagger.v3.oas.annotations.media.Schema schema = AnnotationsUtils.hasArrayAnnotation(p.array()) ? p.array().schema() : p.schema();
         boolean explode = true;
-        if ("form".equals(parameter.getIn())){
-            return true;
-        }
         if (schema != null) {
             Class implementation = schema.implementation();
             if (implementation == Void.class) {
-                if (!schema.type().equals("object") && !schema.type().equals("array")) {
+                if (!schema.type().equals("object") && !schema.type().equals("array") && !schema.type().isEmpty()) {
+                    explode = false;
+                }
+                if (schema.types().length != 0 &&
+                        (!Arrays.asList(schema.types()).contains("array") && !Arrays.asList(schema.types()).contains("object"))) {
                     explode = false;
                 }
             }

Diff for: modules/swagger-jaxrs2/src/test/java/io/swagger/v3/jaxrs2/ReaderTest.java

@@ -82,6 +82,7 @@
 import io.swagger.v3.jaxrs2.resources.Ticket3587Resource;
 import io.swagger.v3.jaxrs2.resources.Ticket3731BisResource;
 import io.swagger.v3.jaxrs2.resources.Ticket3731Resource;
+import io.swagger.v3.jaxrs2.resources.Ticket4065Resource;
 import io.swagger.v3.jaxrs2.resources.Ticket4412Resource;
 import io.swagger.v3.jaxrs2.resources.Ticket4446Resource;
 import io.swagger.v3.jaxrs2.resources.Ticket4483Resource;
@@ -5311,4 +5312,34 @@ public void testTicket4879() {
         SerializationMatchers.assertEqualsToYaml31(openAPI, yaml);
         ModelConverters.reset();
     }
+
+    @Test(description = "test explode FALSE")
+    public void testTicket4065() {
+        ModelConverters.reset();
+        SwaggerConfiguration config = new SwaggerConfiguration();
+        Reader reader = new Reader(config);
+
+        OpenAPI openAPI = reader.read(Ticket4065Resource.class);
+        String yaml = "openapi: 3.0.1\n" +
+                "paths:\n" +
+                "  /bar:\n" +
+                "    get:\n" +
+                "      operationId: test\n" +
+                "      parameters:\n" +
+                "      - name: blub\n" +
+                "        in: query\n" +
+                "        explode: false\n" +
+                "        schema:\n" +
+                "          type: array\n" +
+                "          items:\n" +
+                "            type: integer\n" +
+                "            format: int64\n" +
+                "      responses:\n" +
+                "        default:\n" +
+                "          description: default response\n" +
+                "          content:\n" +
+                "            application/json: {}\n";
+        SerializationMatchers.assertEqualsToYaml31(openAPI, yaml);
+        ModelConverters.reset();
+    }
 }

Diff for: modules/swagger-jaxrs2/src/test/java/io/swagger/v3/jaxrs2/resources/Ticket4065Resource.java

@@ -0,0 +1,19 @@
+package io.swagger.v3.jaxrs2.resources;
+
+import io.swagger.v3.oas.annotations.Parameter;
+import io.swagger.v3.oas.annotations.enums.Explode;
+import io.swagger.v3.oas.annotations.enums.ParameterIn;
+
+import javax.ws.rs.GET;
+import javax.ws.rs.Path;
+import javax.ws.rs.Produces;
+
+@Path("/bar")
+public class Ticket4065Resource {
+    @GET
+    @Path("")
+    @Produces({"application/json"})
+    public void test(
+            @Parameter(in = ParameterIn.QUERY, name = "blub", explode = Explode.FALSE) Long[] ids
+    ) {}
+}