Make deepLinking dynamic #4781
Closed
Make deepLinking dynamic #4781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sal-pal
force-pushed
the
ft/3958-make-deeplinking-dynamic
branch
from
ee8980c to
eeddbda
Compare
In order for Swagger-UI to scroll immediately after a deepLink is clicked, each tag and operation's ref is collected in the beginning of the app's lifecycle.
This is done by making the markdown component remove `target=_blank` from each anchor that has an href value starting with `#/`.
sal-pal
force-pushed
the
ft/3958-make-deeplinking-dynamic
branch
from
a2f1a3f to
7f80bb5
Compare
shockey
suggested changes
Aug 24, 2018
There was a problem hiding this comment.
Hi @srpalomino! I identified regressions which need to be addressed before this can move forward to a full review.
Using the configuration ?url=http://petstore.swagger.io/v2/swagger.json&deepLinking=true:
- expanding a tag or operation no longer updates the URL fragment
- reloading the page with the fragment
#/petno longer scrolls to the correct tag - reloading the page with the fragment
#/pet/addPetno longer scrolls to the correct operation
|
closing due to inactivity. happy to consider this again if the requested changes are taken care of — just open a new PR and we'll pick it back up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3958
After clicking a deepLink, a tag or operation is shown and scrolled to without needing to refresh the page.
This is achieved by the following:
target=_blankfrom all anchors having#/in its href value.