Skip to content

Commit fc5438d

Browse files
committed
Delete SFSafariViewController instance in case of crash
1 parent 67f2905 commit fc5438d

File tree

4 files changed

+64
-57
lines changed

4 files changed

+64
-57
lines changed

example/Gemfile.lock

+11-11
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ GEM
55
base64
66
nkf
77
rexml
8-
activesupport (7.2.2)
8+
activesupport (7.2.2.1)
99
base64
1010
benchmark (>= 0.3)
1111
bigdecimal
@@ -24,8 +24,8 @@ GEM
2424
json (>= 1.5.1)
2525
atomos (0.1.3)
2626
base64 (0.2.0)
27-
benchmark (0.3.0)
28-
bigdecimal (3.1.8)
27+
benchmark (0.4.0)
28+
bigdecimal (3.1.9)
2929
claide (1.1.0)
3030
cocoapods (1.15.2)
3131
addressable (~> 2.8)
@@ -66,30 +66,30 @@ GEM
6666
cocoapods-try (1.2.0)
6767
colored2 (3.1.2)
6868
concurrent-ruby (1.3.4)
69-
connection_pool (2.4.1)
69+
connection_pool (2.5.0)
7070
drb (2.2.1)
7171
escape (0.0.4)
7272
ethon (0.16.0)
7373
ffi (>= 1.15.0)
74-
ffi (1.17.0)
74+
ffi (1.17.1)
7575
fourflusher (2.3.1)
7676
fuzzy_match (2.0.4)
7777
gh_inspector (1.1.3)
7878
httpclient (2.8.3)
7979
i18n (1.14.6)
8080
concurrent-ruby (~> 1.0)
81-
json (2.7.5)
82-
logger (1.6.1)
83-
minitest (5.25.1)
81+
json (2.9.1)
82+
logger (1.6.4)
83+
minitest (5.25.4)
8484
molinillo (0.8.0)
8585
nanaimo (0.3.0)
8686
nap (1.1.0)
8787
netrc (0.11.0)
8888
nkf (0.2.0)
8989
public_suffix (4.0.7)
90-
rexml (3.3.9)
90+
rexml (3.4.0)
9191
ruby-macho (2.5.1)
92-
securerandom (0.3.1)
92+
securerandom (0.4.1)
9393
typhoeus (1.4.1)
9494
ethon (>= 0.9.0)
9595
tzinfo (2.0.6)
@@ -114,4 +114,4 @@ RUBY VERSION
114114
ruby 3.3.4p94
115115

116116
BUNDLED WITH
117-
2.5.18
117+
2.6.2

example/ios/Podfile.lock

+44-44
Original file line numberDiff line numberDiff line change
@@ -1743,63 +1743,63 @@ SPEC CHECKSUMS:
17431743
fmt: 10c6e61f4be25dc963c36bd73fc7b1705fe975be
17441744
glog: 08b301085f15bcbb6ff8632a8ebaf239aae04e6a
17451745
hermes-engine: 46f1ffbf0297f4298862068dd4c274d4ac17a1fd
1746-
RCT-Folly: bf5c0376ffe4dd2cf438dcf86db385df9fdce648
1746+
RCT-Folly: 84578c8756030547307e4572ab1947de1685c599
17471747
RCTDeprecation: fde92935b3caa6cb65cbff9fbb7d3a9867ffb259
17481748
RCTRequired: 75c6cee42d21c1530a6f204ba32ff57335d19007
17491749
RCTTypeSafety: 7e6fe47bfb693c50d4669db1a480ca5331795f5b
17501750
React: 8e73704cdd5c7f801936776d2fc434c605a7827b
17511751
React-callinvoker: fa27d1e091e683de88f576e6a5d4efc171929a4c
1752-
React-Core: 8dd14bffcc9b877091b698e45701160669a31f91
1753-
React-CoreModules: b4437acf2ef25ce3689c84df661dc5d806559b35
1754-
React-cxxreact: 6125cd820da7e18f9ca8343b3c42ee61634a4e0d
1752+
React-Core: 948deed7fa720eeb0d901ff9e45c3719767dab5f
1753+
React-CoreModules: a11ba75f64245d12a0869203664a802c11594c43
1754+
React-cxxreact: a5ce05f8a0a1398958523f948fce00d4c8ce38ff
17551755
React-debug: f474f5c202a277f76c81bf7cf26284f2c09880d7
1756-
React-defaultsnativemodule: 7141fa704531cbf7a7e7af3bc02adfa367e831a7
1757-
React-domnativemodule: c1806b8584a53ed912012a4d8b2c6f96a84c77a3
1758-
React-Fabric: ba9636cfc7f9b77df6cb7edb2c70d0237026404b
1759-
React-FabricComponents: c408da05a4ea5ba071732245b4a7f48f904e610a
1760-
React-FabricImage: c409858f319f11709b49ffa6c5bca4faf794cb44
1756+
React-defaultsnativemodule: 41cc9a60277f1bec4b258df324e28705ac00b91a
1757+
React-domnativemodule: 4fe895d9e4aa99590700c5a5f9ff5706e9481ed7
1758+
React-Fabric: bbdcc01a98528846efacf0767567a8e76df794bb
1759+
React-FabricComponents: ab8967c5898d88f37486df0eb0111384c498d821
1760+
React-FabricImage: 7a06db59488b37f509dee73fa0b2811608a67058
17611761
React-featureflags: 929732439d139ac0662e08f009f1a51ed2b91ed3
1762-
React-featureflagsnativemodule: 02dd903d4cbe4fae0e6cd02bc32a09d30543282f
1763-
React-graphics: a5cad35307286e9f83e212834e95fef4010d03d0
1764-
React-hermes: 14aafa9630579b84c2167b563bdb8c811970a03e
1765-
React-idlecallbacksnativemodule: 69581ac44bd355acce3739c3fe380c0f6d7a6d09
1766-
React-ImageManager: 41945afb3ace0c52255057ec4ae6af6f5a23539f
1767-
React-jserrorhandler: ecbc4622df7ab3d0066a4313cde4172d45745508
1768-
React-jsi: ff383df87c7047e976a66be45df59e4e0db5346e
1769-
React-jsiexecutor: 2bb8b172f226f2f502521d33dd7666e701d45f45
1770-
React-jsinspector: 4d51b903543f21076b658ef8412f3102778dbc92
1771-
React-jsitracing: 654f4d9cb9fd99b3d96f239ceb215ae49ce28ac0
1772-
React-logger: 97c9dafae1f1a638001a9d1d0e93d431f2f9cb7b
1773-
React-Mapbuffer: 3146a13424f9fec2ea1f1462d49d566e4d69b732
1774-
React-microtasksnativemodule: 02d218c79c72d373a92a8552183f4ead0d1c6e05
1762+
React-featureflagsnativemodule: b88d53b6d63ee037c5cdefb9861edfd16b4afce1
1763+
React-graphics: 6367275cc82d631c588a7146fd8dc69ec2f447e8
1764+
React-hermes: b9bbe9c808d7ab1750ce089b243b03e4a099af63
1765+
React-idlecallbacksnativemodule: 6fff2280f860f29a3c049695d3ef04c8f70212aa
1766+
React-ImageManager: 5b001b9e974f5ba81f0645d3d799e2a20c61d91e
1767+
React-jserrorhandler: 35e5e5a5a99b7b36c3802a2d12ca86889ed5982a
1768+
React-jsi: d0d8c4019fd91d0cb4b432f2518e08dc37433a13
1769+
React-jsiexecutor: 1cdaf24e36919d899250938f0f6c79ec1a256923
1770+
React-jsinspector: 2fabeadbd0eb1cbd83a6fc2026fb38c75b200947
1771+
React-jsitracing: 7c7c89c963893efd25e0d04c23e854b9a93e0b7e
1772+
React-logger: 7b5b458327a1ff0d7e5a349430d1ed133dcebaa3
1773+
React-Mapbuffer: 0d88ad9afa9e195dd7634424bde1d38e4129e646
1774+
React-microtasksnativemodule: 17234f35d37e6ed388e18a6314210b3b9e051219
17751775
React-nativeconfig: 93fe8c85a8c40820c57814e30f3e44b94c995a7b
1776-
React-NativeModulesApple: b3e076fd0d7b73417fe1e8c8b26e3c57ae9b74aa
1777-
React-perflogger: 1c55bcd3c392137cbaf0d21d8bb87ce9a0cebb15
1778-
React-performancetimeline: e89249db10b8f7bf8f72c2e9bd471ac37d48b753
1776+
React-NativeModulesApple: a4457b73e63e983db66d66612160006bccb00ad5
1777+
React-perflogger: 3140b7778984a486db80d4d2aeaa266cae4eb8c7
1778+
React-performancetimeline: 41c100bc1299d7b150821b99cf26661c51ed9ab0
17791779
React-RCTActionSheet: 9407c795fbeee35da2dae3cd6b5c4e5da6ff8bd3
1780-
React-RCTAnimation: 7ee1c2a77aab7e5c568611d8092a994cfcbe8410
1781-
React-RCTAppDelegate: 10c2b0c434baf5a71b53d5c86c4d8d0dbd6bb380
1782-
React-RCTBlob: 761072706300d22624ec2d6bf860b77d95ebd3da
1783-
React-RCTFabric: 871d38933a94554d9e27963aa4bb67184dc7529e
1784-
React-RCTImage: b6614fde902ec9647f15236da94df2d24c40523f
1785-
React-RCTLinking: 25950eda5d5f786bfb3daf513ea7d848555a2a93
1786-
React-RCTNetwork: b69407c4119fd7a1cc07db4a94563f2546f8770d
1787-
React-RCTSettings: b310a4923446c3a8950fa866c8cf83323a9e1b87
1788-
React-RCTText: 77c6eda5be1dee657f5183f75fe0fdcdb7b2b35d
1789-
React-RCTVibration: b4889c7702aea1b07316be1ec0de2e36e9a4d077
1780+
React-RCTAnimation: 48e5c6b541fd4c7a96c333e61974c3de34bbe849
1781+
React-RCTAppDelegate: 602daadf2452a56ca54a6257052ddba89e680486
1782+
React-RCTBlob: f67be4e0fbe51db1574aec402754054ab9c39668
1783+
React-RCTFabric: ee6706069cbc4e1ffd5f23553e999a42b08414f7
1784+
React-RCTImage: 57894a0e42502461d87449bec6cb0f124a49a93b
1785+
React-RCTLinking: abd71677bc3353327bec26b0ccd0a0c3960efa1c
1786+
React-RCTNetwork: 2e91efa49b63e54a9782922e5ca1d09ff2789341
1787+
React-RCTSettings: fd13eebaa3f9af0b56a0ecb053b108e160fbfe07
1788+
React-RCTText: 4cd7c87db1e1da51a96b86ce39c5468c1dbaae60
1789+
React-RCTVibration: 579f64ceb06701eca3004a500169e1152c1ef7d2
17901790
React-rendererconsistency: 5ef1c4642fd6365bf6d5d4e29a3ae02c3a1b8980
1791-
React-rendererdebug: 7f6a24cbb5008a22ccb34a0d031a259b006facf6
1791+
React-rendererdebug: 8952e1ad914c680d4978916a9eed7c6dc85301d7
17921792
React-rncore: 0e5394ce20a9d2bf12409d14395588c7b9e6e9ce
1793-
React-RuntimeApple: bbe293f233d17304c9597309acde7505080fd53d
1794-
React-RuntimeCore: 5a1cbfc3e7af4fbdea2b9b1efd39cd51a4d4006f
1793+
React-RuntimeApple: f5ed38fba1230713313e88e750dcad06948ba625
1794+
React-RuntimeCore: 0fc488daf136f05d96349772828ccf64f66d6d2a
17951795
React-runtimeexecutor: ffac5f09795a5e881477e0d72a0fa6385456bed3
1796-
React-RuntimeHermes: 0a1fd1c150faed8341887dd89895eeb8d4d2d3c5
1797-
React-runtimescheduler: e7df538274de0c65736068e40efc0d2228f42d0d
1796+
React-RuntimeHermes: b8f395d41116c3bdf3373e87c39a856f69c3fff8
1797+
React-runtimescheduler: 933c72afd4f285b2bb473c0de2482ee250f3e735
17981798
React-timing: b3b233fe819d9e5b6ca32b605aa732621bdfa5aa
1799-
React-utils: 5362bd16a9563f9916e7a56c011ddc533507650f
1800-
ReactCodegen: 865bafc5c17ec2181620ced1a32c39c38ab2951d
1801-
ReactCommon: 422e364463f33e336fc4db196aeb50fd801d90d6
1802-
RNSwanBrowser: bda97b0323e7d1aade28e47318b855ee1a3e6d5b
1799+
React-utils: 0c825829a8e2ca39bb049d95f270a2dbf39ecb05
1800+
ReactCodegen: 3b0ff1c9015e3ebcf2bd2f8559995c74bfacf8a1
1801+
ReactCommon: c21a3d6a8d3e98b6e99730139a52f59f0beea89d
1802+
RNSwanBrowser: f318c7239f91b5ba00f67ac99cdd416282f058c6
18031803
SocketRocket: d4aabe649be1e368d1318fdf28a022d714d65748
18041804
Yoga: db69236006b8b1c6d55ab453390c882306cbf219
18051805

example/ios/RNSwanBrowserExample.xcodeproj/project.pbxproj

+8-2
Original file line numberDiff line numberDiff line change
@@ -384,7 +384,10 @@
384384
"-DFOLLY_CFG_NO_COROUTINES=1",
385385
"-DFOLLY_HAVE_CLOCK_GETTIME=1",
386386
);
387-
OTHER_LDFLAGS = "$(inherited) ";
387+
OTHER_LDFLAGS = (
388+
"$(inherited)",
389+
" ",
390+
);
388391
REACT_NATIVE_PATH = "${PODS_ROOT}/../../node_modules/react-native";
389392
SDKROOT = iphoneos;
390393
SWIFT_ACTIVE_COMPILATION_CONDITIONS = "$(inherited) DEBUG";
@@ -453,7 +456,10 @@
453456
"-DFOLLY_CFG_NO_COROUTINES=1",
454457
"-DFOLLY_HAVE_CLOCK_GETTIME=1",
455458
);
456-
OTHER_LDFLAGS = "$(inherited) ";
459+
OTHER_LDFLAGS = (
460+
"$(inherited)",
461+
" ",
462+
);
457463
REACT_NATIVE_PATH = "${PODS_ROOT}/../../node_modules/react-native";
458464
SDKROOT = iphoneos;
459465
USE_HERMES = true;

ios/RNSwanBrowser.mm

+1
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,7 @@ - (void)open:(NSString *)url
118118

119119
resolve(nil);
120120
} @catch (NSException *exception) {
121+
_safariVC = nil;
121122
reject(exception.name, exception.reason, nil);
122123
}
123124
}

0 commit comments

Comments
 (0)