Fix CRAN team comments. Add lty parameter to plot. Update website to Boostrap 5.

Author: sjmgarnier

CRAN-SUBMISSION

@@ -0,0 +1,3 @@
+Version: 0.11.0
+Date: 2022-12-11 12:27:45 UTC
+SHA: e5c63baf599d025554042c1d19e9ad315574261c

DESCRIPTION

@@ -13,10 +13,10 @@ Authors@R: c(
   )
 Maintainer: Simon Garnier <[email protected]>
 Description: Splits data into Gaussian type clusters using the Cross-Entropy 
-    Clustering (CEC) method. This method allows for the simultaneous use of 
-    various type of Gaussian mixture models, for performing the reduction of 
+    Clustering ('CEC') method. This method allows for the simultaneous use of 
+    various types of Gaussian mixture models, for performing the reduction of 
     unnecessary clusters, and for discovering new clusters by splitting them. 
-    CEC is based on the work of Spurek, P. and Tabor, J. (2014) 
+    'CEC' is based on the work of Spurek, P. and Tabor, J. (2014) 
     <doi:10.1016/j.patcog.2014.03.006>.
 ByteCompile: true
 URL: https://github.com/swarm-lab/cec,

R/cec.R

@@ -175,8 +175,6 @@
 #' m3[,2] <- m3[, 2] - 5
 #' m <- rbind(m1, m2, m3)
 #'
-#' oldpar <- graphics::par(ask = TRUE)
-#' on.exit(graphics::par(oldpar))
 #' plot(m, cex = 0.5, pch = 19)
 #'
 #' ## Clustering result:
@@ -452,8 +450,6 @@ cec.interactive <- function(x,
                             keep.removed = FALSE, 
                             readline = TRUE) {
     old.ask <- graphics::par()["ask"]
-    on.exit(graphics::par(old.ask))
-    
     n <- ncol(x)
 
     if (n != 2) {
@@ -514,5 +510,6 @@ cec.interactive <- function(x,
         ignore <- readline(prompt = "Press <Enter>:")
     }
 
+    par(old.ask)
     Z
 }

R/plot.cec.R

@@ -24,11 +24,14 @@
 #' 
 #' @param pch.centers The same as \code{pch}, except that it applies only to the 
 #'  centers' means.
-#' 
+#'  
+#' @param ellipses If this parameter is TRUE, covariance ellipses will be drawn.
+#'
 #' @param ellipses.lwd The line width of the covariance ellipses. See \code{lwd}
 #'  in \code{\link{par}} for more details.
-#' 
-#' @param ellipses If this parameter is TRUE, covariance ellipses will be drawn.
+#'  
+#' @param ellipses.lty The line type of the covariance ellipses. See \code{lty}
+#'  in \code{\link{par}} for more details.
 #' 
 #' @param model If this parameter is TRUE, the model (expected) covariance will
 #'  be used for each cluster instead of the sample covariance (MLE) of the 
@@ -52,8 +55,8 @@
 #'
 #' @export
 plot.cec <- function(x, col, cex = 0.5, pch = 19, cex.centers = 1, 
-                     pch.centers = 8,  ellipses.lwd = 4, ellipses = TRUE, 
-                     model = TRUE, xlab, ylab, ...) {
+                     pch.centers = 8, ellipses = TRUE, ellipses.lwd = 4, 
+                     ellipses.lty = 2, model = TRUE, xlab, ylab, ...) {
     if (ncol(x$data) != 2) {
         stop("Plotting is available only for 2-dimensional data.")
     }
@@ -96,7 +99,7 @@ plot.cec <- function(x, col, cex = 0.5, pch = 19, cex.centers = 1,
                 tryCatch({
                     cov <- covs[[i]]
                     pts <- ellipse(means[i, ], cov)
-                    graphics::lines(pts, lwd = ellipses.lwd)
+                    graphics::lines(pts, lwd = ellipses.lwd, lty = ellipses.lty)
                 },
                 finally = {})
             }

_pkgdown.yml

@@ -1,7 +1,7 @@
 url: https://swarm-lab.github.io/cec/
 
 template:
-  params:
+    bootstrap: 5
     bootswatch: simplex
 
 authors:

cran-comments.md

@@ -35,6 +35,26 @@ There are currently no downstream dependencies for this package.
 
 ## CRAN team comments
 
+"Please always write package names, software names and API (application
+programming interface) names in single quotes in title and description.
+e.g: --> 'CEC'
+Please note that package names are case sensitive."
+
+Fixed.
+
+"Please do not use on.exit() to reset user's options(), working directory
+or par() after you changed it in examples and vignettes and demos. e.g.:
+man/cec.Rd
+Please reset in the following way
+e.g.:
+oldpar <- par(mfrow = c(1,2))
+...
+par(oldpar)"
+
+Fixed. 
+
+---
+
 The package appeared to have been "orphaned" and I am "adopting" it as new 
 maintainer. CRAN check errors were not corrected for months, there has not been 
 any activity on the package's GitHub repository in more than a year, and the