Skip to content

commands: unescape '\' from IPC commands as well #6123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fenveireth
Copy link
Contributor

Fixes #5652.
Was not consistent with handling of commands read from config file

Fixes swaywm#5652.
Was not consistent with handling of commands read from config file
@emersion
Copy link
Member

Hm, shouldn't we avoid doing the escaping in the first place?

@fenveireth
Copy link
Contributor Author

fenveireth commented Mar 21, 2021

That was my first reflex, but turns out it makes it overall easier to create workspaces you are locked out of.
Invoked edge case for the escaping is using a workspace called "1" (double-quotes part of the display name). That's arguably just asking for trouble, but once it's in there, we need some way to make the name precisely round-trip

As of now, sway IPC-side lets you do that by putting problematic characters individually between single-quotes, if the first character in the argument is single-quoted.
This is not compatible with i3, which will not interpret the single-quoting, and will interpret ' \ ' shell-style

@mreppen
Copy link

mreppen commented Nov 12, 2021

Possibly relevant (also issue with quoting \):
#5931

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

swaybar: cannot click(move) on workspaces with \ in the name
3 participants