mouse_warping unhides cursor on keyboard focus change

[soubaer]

Description:

I use this config:

mouse_warping container
seat seat0 hide_cursor 1000

When I change focus with the keyboard with focus <direction>, the cursor warps to the new container as desired but becomes visible for 1 second.

This is annoying, the cursor keeps flashing back on every focus change. It is also an issue with mouse_warping output at a lesser extent.

Programmatic cursor warps should update the cursor coordinates without making it visible again. Only physical mouse movement should unhide the cursor.

Suggested fix:

In sway/input/cursor.c, remove the cursor_unhide(cursor); calls in:

• cursor_warp_to_container() (line 1178)
• cursor_warp_to_workspace() (line 1195)

I can submit a PR if you're interested.

[soubaer]

In mouse_warping output mode, we can argue that the cursor unhiding helps the user to figure out that the cursor teleports when you jump between outputs, but not between containers. But when set to container, it is completely unnecessary since you quickly become aware that your cursor will always be at the center of the container you switched focus to (besides, you set this option yourself since it's not the default).

The point is that this current behavior makes container setting quite incompatible with a cursor autohide timer from a UX perspective. You set a cursor autohide timer because you want your workspace clean without distractions and the constant flashing defeats that purpose. It's a small form of torture for those sensitive to it and it dissuades you from setting the setting on container even if it is the behavior you actually want.