This repository was archived by the owner on Nov 1, 2021. It is now read-only.
backend/drm: add support for hotplug_mode_update #2712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The X11 backend uses the Present extension to schedule frames. The refresh rate is unused.
This allows backends to request the compositor to change the state of an output. References: swaywm#2300 (comment)
This was referenced Feb 3, 2021
|
Do we really need that new |
hedgepigdaniel
force-pushed
the
feat/hotplug_mode_update
branch
6 times, most recently
from
8203e97 to
74cac23
Compare
For connectors that set the hotplug_mode_update prop (usually connectors corresponding to virtualised outputs), ignore modes other than the preferred mode, treat the preferred mode as a custom mode, and do not add it to the output->modes list. When the preferred mode changes, send a request_state event on the output to request for the compositor to change to the new mode.
hedgepigdaniel
force-pushed
the
feat/hotplug_mode_update
branch
from
74cac23 to
e0b4379
Compare
|
Ok, I think I've managed to simplify it including not introducing a new mode type. |
|
wlroots has migrated to gitlab.freedesktop.org. This pull request has been moved to: https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/2712 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2188
Depends on #2693
Replaces #2628
As @emersion suggested in #2628 (comment), in the case that the
hotplug_mode_updateprop is set on a connector, the DRM backend should behave more like the Wayland/X11 backends:output->modeslistWhen
hotplug_mode_updateis not set,(struct wlr_drm_connector).desired_mode.and(struct wlr_output).current_modepoint to modes in the(struct wlr_output).modesarray. For connectors withhotplug_mode_update, this is not the case, so they have to be freed when the desired/current mode changes.