Fix warnings generated when running pytest:

dgburr · dgburr · commit caa902953114 · 2025-10-25T03:31:07.000+02:00
1. pytest.mark.slow is not defined
2. Unsupported escape sequence `\_` in comments
3. Prevent test_sbp2json_unbuffered() from failing once and then passing
   the second time
4. User warning triggered when attempting to import sbp.jit
diff --git a/c/include/libsbp/signing/MSG_ECDSA_SIGNATURE.h b/c/include/libsbp/signing/MSG_ECDSA_SIGNATURE.h
@@ -45,7 +45,7 @@ extern "C" {
  */
 typedef struct {
   /**
-   * Describes the format of the `signed\_messages` field below.
+   * Describes the format of the `signed_messages` field below.
    */
   u8 flags;
 
diff --git a/c/include/libsbp/signing/MSG_ECDSA_SIGNATURE_DEP_A.h b/c/include/libsbp/signing/MSG_ECDSA_SIGNATURE_DEP_A.h
@@ -44,7 +44,7 @@ extern "C" {
  */
 typedef struct {
   /**
-   * Describes the format of the `signed\_messages` field below.
+   * Describes the format of the `signed_messages` field below.
    */
   u8 flags;
 
diff --git a/c/include/libsbp/signing/MSG_ECDSA_SIGNATURE_DEP_B.h b/c/include/libsbp/signing/MSG_ECDSA_SIGNATURE_DEP_B.h
@@ -44,7 +44,7 @@ extern "C" {
  */
 typedef struct {
   /**
-   * Describes the format of the `signed\_messages` field below.
+   * Describes the format of the `signed_messages` field below.
    */
   u8 flags;
 
diff --git a/python/docs/source/index.rst b/python/docs/source/index.rst
@@ -71,6 +71,7 @@ Messages:
    sbp.flash
    sbp.gnss
    sbp.imu
+   sbp.integrity
    sbp.linux
    sbp.logging
    sbp.mag
@@ -81,9 +82,11 @@ Messages:
    sbp.piksi
    sbp.sbas
    sbp.settings
+   sbp.signing
    sbp.solution_meta
    sbp.ssr
    sbp.system
+   sbp.telemetry
    sbp.tracking
    sbp.user
    sbp.vehicle
diff --git a/python/pytest.ini b/python/pytest.ini
@@ -1,3 +1,4 @@
 [pytest]
 # fftmonitor.py requires numpy
 addopts = --doctest-modules --ignore='sbp/client/util/fftmonitor.py' --flakes
+markers = slow: mark test as slow.
diff --git a/python/sbp/jit/__init__.py b/python/sbp/jit/__init__.py
diff --git a/python/sbp/msg.py b/python/sbp/msg.py
@@ -34,13 +34,6 @@
 _CRC_PARSER = struct.Struct(_CRC_FMT)
 
 
-def try_import_jit():
-  from warnings import warn
-
-  warn("sbp.jit has been removed", UserWarning, stacklevel=1)
-  return None
-
-
 class UnpackError(ValueError):
   pass
 
diff --git a/python/sbp/sbp2json.py b/python/sbp/sbp2json.py
@@ -184,7 +184,7 @@ def iter_messages_buffered(fp):
 
 
 def sbp_main(args):
-    reader = io.open(args.file.fileno(), 'rb')
+    reader = io.open(args.file.fileno(), 'rb', closefd=False)
     include = set(args.include)
     iter_fn = iter_messages_unbuffered if args.unbuffered else iter_messages_buffered
 
diff --git a/python/sbp/signing.py b/python/sbp/signing.py
@@ -623,7 +623,7 @@ class MsgEcdsaSignature(SBP):
   sbp : SBP
     SBP parent object to inherit from.
   flags : int
-    Describes the format of the `signed\_messages` field below.
+    Describes the format of the `signed_messages` field below.
   stream_counter : int
     Signature message counter. Zero indexed and incremented with each
     signature message.  The counter will not increment if this message was in
@@ -754,7 +754,7 @@ class MsgEcdsaSignatureDepB(SBP):
   sbp : SBP
     SBP parent object to inherit from.
   flags : int
-    Describes the format of the `signed\_messages` field below.
+    Describes the format of the `signed_messages` field below.
   stream_counter : int
     Signature message counter. Zero indexed and incremented with each
     signature message.  The counter will not increment if this message was in
@@ -893,7 +893,7 @@ class MsgEcdsaSignatureDepA(SBP):
   sbp : SBP
     SBP parent object to inherit from.
   flags : int
-    Describes the format of the `signed\_messages` field below.
+    Describes the format of the `signed_messages` field below.
   stream_counter : int
     Signature message counter. Zero indexed and incremented with each
     signature message.  The counter will not increment if this message was in
diff --git a/python/tests/sbp/test_deprecation.py b/python/tests/sbp/test_deprecation.py
diff --git a/python/tests/sbp/test_sbp2json.py b/python/tests/sbp/test_sbp2json.py
@@ -11,6 +11,7 @@
 from .utils import PYTHON_ROOT
 import sbp.sbp2json
 import os
+import pytest
 
 TEST_DATA = os.path.join(PYTHON_ROOT, "..", "test_data", "benchmark.sbp")
 
@@ -37,13 +38,15 @@ def counter(args, res):
 
 # make sure that we parse exactly 150000 SBP messages from TEST_DATA
 # when running sbp2json without the --unbuffered flag
+@pytest.mark.slow
 def test_sbp2json_buffered():
     msg_count = get_message_count(False)
     assert msg_count == 150000
 
 
 # make sure that we parse exactly 150000 SBP messages from TEST_DATA
 # when running sbp2json with the --unbuffered flag
+@pytest.mark.slow
 def test_sbp2json_unbuffered():
     msg_count = get_message_count(True)
     assert msg_count == 150000
diff --git a/spec/yaml/swiftnav/sbp/signing.yaml b/spec/yaml/swiftnav/sbp/signing.yaml
@@ -235,7 +235,7 @@ definitions:
       fields:
         - flags:
             type: u8
-            desc: Describes the format of the `signed\_messages` field below.
+            desc: Describes the format of the `signed_messages` field below.
             fields:
               - 0-1:
                   desc: CRC type
@@ -287,7 +287,7 @@ definitions:
       fields:
         - flags:
             type: u8
-            desc: Describes the format of the `signed\_messages` field below.
+            desc: Describes the format of the `signed_messages` field below.
             fields:
               - 0-1:
                   desc: CRC type
@@ -348,7 +348,7 @@ definitions:
       fields:
         - flags:
             type: u8
-            desc: Describes the format of the `signed\_messages` field below.
+            desc: Describes the format of the `signed_messages` field below.
             fields:
               - 0-1:
                   desc: CRC type
