Use gtest instead of check for C tests (#1527)

There are a few issues with using the check library to test the C language bindings:

1. check does not appear to be actively maintained
2. The latest version of check does not compile with recent versions of MinGW64
3. check only used by libsbp; all of the other swift repos have switched over to gtest

This PR converts the C language bindings to use gtest, which means compiling the unit tests as C++ instead of C.

Author: dgburr

.github/workflows/c.yaml

@@ -131,7 +131,7 @@ jobs:
           CC: mips-linux-gnu-gcc
           CXX: mips-linux-gnu-g++
 
-          CMAKEFLAGS: -DCMAKE_EXE_LINKER_FLAGS_RELEASE="-static" -Dgtest_disable_pthreads=ON
+          CMAKEFLAGS: -DCMAKE_EXE_LINKER_FLAGS="-static" -Dgtest_disable_pthreads=ON
 
   bazel:
     name: Bazel

.github/workflows/generator.yaml

@@ -36,7 +36,7 @@ jobs:
 
       - name: Generate tests
         run: |
-          rm c/test/auto_check_*.c c/test/cpp/auto_check_*.cc java/test/auto_check_*.java rust/sbp/tests/integration/auto_check_*.rs
+          rm c/test/auto_check_*.cc c/test/cpp/auto_check_*.cc java/test/auto_check_*.java rust/sbp/tests/integration/auto_check_*.rs
           make gen-c gen-java gen-rust gen-jsonschema gen-haskell gen-python gen-javascript gen-protobuf
           make quicktype
 

.gitmodules

@@ -1,9 +1,6 @@
 [submodule "c/cmake/common"]
 	path = c/cmake/common
 	url = https://github.com/swift-nav/cmake.git
-[submodule "c/third_party/check"]
-	path = c/third_party/check
-	url = https://github.com/swift-nav/check.git
 [submodule "c/third_party/googletest"]
 	path = c/third_party/googletest
 	url = https://github.com/google/googletest.git

MODULE.bazel

@@ -27,7 +27,6 @@ register_toolchains(
     "@rules_swiftnav//cc/toolchains/llvm/x86_64-darwin:cc-toolchain-x86_64-darwin",
 )
 
-bazel_dep(name = "check", version = "0.15.2.bcr.1", dev_dependency = True)
 bazel_dep(name = "googletest", version = "1.13.0", dev_dependency = True)
 
 bazel_dep(name = "hedron_compile_commands", dev_dependency = True)

WORKSPACE.bazel

@@ -57,9 +57,3 @@ local_repository(
     name = "googletest",
     path = "c/third_party/googletest",
 )
-
-new_local_repository(
-    name = "check",
-    build_file = "@rules_swiftnav//third_party:check.BUILD",
-    path = "c/third_party/check",
-)

c/BUILD.bazel

@@ -60,22 +60,22 @@ filegroup(
     visibility = ["//visibility:public"],
 )
 
-SBP_C_SOURCES = glob(["test/auto*.c"])
+SBP_C_SOURCES = glob(["test/auto*.cc"])
 
-swift_c_test(
+swift_cc_test(
     name = "sbp-test",
     srcs = [
-        "test/check_main.c",
-        "test/check_edc.c",
-        "test/check_sbp.c",
-        "test/check_bitfield_macros.c",
-        "test/check_suites.h",
+        "test/test_edc.cc",
+        "test/test_sbp.cc",
+        "test/test_bitfield_macros.cc",
+        "test/test_utils.cc",
+        "test/test_utils.h",
     ] + SBP_C_SOURCES,
     includes = ["include/libsbp"],
     type = UNIT,
     deps = [
         ":sbp",
-        "@check",
+        "@googletest//:gtest_main",
     ],
 )
 

c/CMakeLists.txt

@@ -15,14 +15,14 @@ include(ClangTidy)
 swift_create_project_options(
     HAS_TESTS
     HAS_DOCS
-    TEST_PACKAGES "Check"
+    TEST_PACKAGES "Googletest"
     )
 include(CodeCoverage)
 include(SwiftTargets)
 include(TestTargets)
 add_code_coverage_all_targets()
 # TODO: Reformatting is limited to generated files; it should be expanded to cover all files
-swift_setup_clang_format(PATTERNS 'include/*.h' 'test/*.c' 'test/*.h' 'test/cpp/*.cc')
+swift_setup_clang_format(PATTERNS 'include/*.h' 'test/*.cc' 'test/*.h' 'test/cpp/*.cc')
 
 if(libsbp_BUILD_TESTS)
   find_package(Googletest)

c/scripts/clang-format.sh

@@ -8,4 +8,4 @@ set -e -x
 GENERATED_HEADERS=$(grep -rl --include="*.h" "Automatically generated" include/libsbp/* src/)
 GENERATED_C_SOURCES=$(grep -rl --include="*.c" "Automatically generated" src/)
 CLANG_FORMAT=clang-format-11
-$CLANG_FORMAT -i $GENERATED_HEADERS $GENERATED_C_SOURCES test/*.c test/*.h test/auto* test/cpp/auto*
+$CLANG_FORMAT -i $GENERATED_HEADERS $GENERATED_C_SOURCES test/*.cc test/*.h test/auto* test/cpp/auto*

c/test/CMakeLists.txt

@@ -1,12 +1,12 @@
 find_package(Threads)
-set(TEST_LIBS ${TEST_LIBS} check Threads::Threads swiftnav::sbp)
+set(TEST_LIBS ${TEST_LIBS} gtest_main Threads::Threads swiftnav::sbp)
 
 # Check needs to be linked against Librt on Linux
 if (${CMAKE_SYSTEM_NAME} STREQUAL "Linux")
   set(TEST_LIBS ${TEST_LIBS} rt)
 endif(${CMAKE_SYSTEM_NAME} STREQUAL "Linux")
 
-FILE(GLOB generated_c_sources auto*.c)
+FILE(GLOB generated_c_sources auto*.cc)
 
 set(TEST_INCLUDES ${PROJECT_SOURCE_DIR}/include/libsbp)
 
@@ -26,24 +26,20 @@ endif()
 swift_add_test(test-libsbp
   UNIT_TEST
   SRCS
-    check_main.c
-    check_edc.c
-    check_sbp.c
-    check_bitfield_macros.c
+    test_edc.cc
+    test_sbp.cc
+    test_bitfield_macros.cc
+    test_utils.cc
     ${generated_c_sources}
   INCLUDE
     ${TEST_INCLUDES}
   LINK
     ${TEST_LIBS}
   )
+swift_set_language_standards(test-libsbp)
 swift_set_compile_options(test-libsbp
   REMOVE
-    -Wpointer-arith
-    -Wformat
-    -Wformat-security
-    -Wformat-y2k
-  ADD
-    -Wformat=0
+    -Wdisabled-optimization
 )
 
 add_subdirectory(cpp)