Skip to content
This repository was archived by the owner on Apr 13, 2021. It is now read-only.
This repository was archived by the owner on Apr 13, 2021. It is now read-only.

Inconsistent save_samples and load_samples definition in peregrine.samples #8

@sudiptakarmakar

Description

@sudiptakarmakar

The declaration for save_samples is
def save_samples(filename, samples, file_format='int8')

and declaration for load_samples is
def load_samples(filename, num_samples=-1, num_skip=0, file_format='piksi')

Because of that, passing minimum number or arguments, if you save a sample it saves in np.int8 format, but when loading, it tries to retrieve that saved sample in piksi format. As a result, returned object is often starkly different from what was saved at first.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions