Merge pull request swiftlang#86065 from cachemeifyoucan/eng/PR-166557713-6.3

adrian-prantl · web-flow · commit 6c559f388786 · 2025-12-17T13:03:23.000-08:00
[6.3][ModuleLoader] Remove `llvm_unreachable` in findModuleFilesInDirectory()
diff --git a/lib/Frontend/ModuleInterfaceLoader.cpp b/lib/Frontend/ModuleInterfaceLoader.cpp
@@ -2384,7 +2384,6 @@ std::error_code ExplicitSwiftModuleLoader::findModuleFilesInDirectory(
     std::unique_ptr<llvm::MemoryBuffer> *ModuleSourceInfoBuffer,
     bool IsCanImportLookup, bool IsFramework,
     bool IsTestableDependencyLookup) {
-  llvm_unreachable("Not supported in the Explicit Swift Module Loader.");
   return std::make_error_code(std::errc::not_supported);
 }
 
@@ -2758,7 +2757,6 @@ std::error_code ExplicitCASModuleLoader::findModuleFilesInDirectory(
     std::unique_ptr<llvm::MemoryBuffer> *ModuleSourceInfoBuffer,
     bool IsCanImportLookup, bool IsFramework,
     bool IsTestableDependencyLookup) {
-  llvm_unreachable("Not supported in the Explicit Swift Module Loader.");
   return std::make_error_code(std::errc::not_supported);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -2384,7 +2384,6 @@ std::error_code ExplicitSwiftModuleLoader::findModuleFilesInDirectory(`
`2384`	`2384`	`std::unique_ptr<llvm::MemoryBuffer> *ModuleSourceInfoBuffer,`
`2385`	`2385`	`bool IsCanImportLookup, bool IsFramework,`
`2386`	`2386`	`bool IsTestableDependencyLookup) {`
`2387`		`- llvm_unreachable("Not supported in the Explicit Swift Module Loader.");`
`2388`	`2387`	`return std::make_error_code(std::errc::not_supported);`
`2389`	`2388`	`}`
`2390`	`2389`
`@@ -2758,7 +2757,6 @@ std::error_code ExplicitCASModuleLoader::findModuleFilesInDirectory(`
`2758`	`2757`	`std::unique_ptr<llvm::MemoryBuffer> *ModuleSourceInfoBuffer,`
`2759`	`2758`	`bool IsCanImportLookup, bool IsFramework,`
`2760`	`2759`	`bool IsTestableDependencyLookup) {`
`2761`		`- llvm_unreachable("Not supported in the Explicit Swift Module Loader.");`
`2762`	`2760`	`return std::make_error_code(std::errc::not_supported);`
`2763`	`2761`	`}`
`2764`	`2762`