Deduplicate scenario file suffixes

Suggested by SonarQube to avoid duplicating the .yaml literal across scenario loading code.

Author: burakemirsezen

src/swiss_ai_model_launch/loadtest/core.py

@@ -8,6 +8,8 @@
 
 import yaml
 
+from swiss_ai_model_launch.loadtest.scenario_files import SCENARIO_SUFFIXES, YAML_SCENARIO_SUFFIXES
+
 from .models import LoadtestConfig, ServerConfig
 
 _BUILTIN_SCENARIOS_DIR = files("swiss_ai_model_launch.assets").joinpath("scenarios")
@@ -16,7 +18,7 @@
 
 def _load_scenario_definition_file(path: Traversable | Path, ext: str) -> dict[str, Any]:
     text = path.read_text()
-    data = yaml.safe_load(text) if ext in (".yaml", ".yml") else json.loads(text)
+    data = yaml.safe_load(text) if ext in YAML_SCENARIO_SUFFIXES else json.loads(text)
     if not isinstance(data, dict):
         raise ValueError(f"Scenario file must contain a top-level object: {path}")
     return data
@@ -27,12 +29,12 @@ def _load_scenario_definition(name: str) -> dict[str, Any] | None:
 
     Supports .yaml, .yml, and .json; returns a plain dict ready for JSON serialization.
     """
-    for ext in (".yaml", ".yml", ".json"):
+    for ext in SCENARIO_SUFFIXES:
         custom_path = _CUSTOM_SCENARIOS_DIR / f"{name}{ext}"
         if custom_path.exists():
             return _load_scenario_definition_file(custom_path, ext)
 
-    for ext in (".yaml", ".yml", ".json"):
+    for ext in SCENARIO_SUFFIXES:
         builtin_path = _BUILTIN_SCENARIOS_DIR.joinpath(f"{name}{ext}")
         if builtin_path.is_file():
             return _load_scenario_definition_file(builtin_path, ext)

src/swiss_ai_model_launch/loadtest/models.py

@@ -8,6 +8,8 @@
 
 import yaml
 
+from swiss_ai_model_launch.loadtest.scenario_files import SCENARIO_SUFFIXES, YAML_SCENARIO_SUFFIXES
+
 
 @dataclass
 class ScenarioConfig:
@@ -27,7 +29,7 @@ def _scenario_suffix(path: Traversable | Path) -> str:
 
 def _load_scenario_file(path: Traversable | Path) -> ScenarioConfig:
     text = path.read_text()
-    data = yaml.safe_load(text) if _scenario_suffix(path) in (".yaml", ".yml") else json.loads(text)
+    data = yaml.safe_load(text) if _scenario_suffix(path) in YAML_SCENARIO_SUFFIXES else json.loads(text)
     return ScenarioConfig(
         name=data["name"],
         max_tokens=data.get("max_tokens", "2048"),
@@ -40,12 +42,12 @@ def load_scenarios() -> list[ScenarioConfig]:
     """Load built-in scenarios, with any user-defined ones from CWD/scenarios/ appended."""
     scenarios: dict[str, ScenarioConfig] = {}
     for path in sorted(_BUILTIN_SCENARIOS_DIR.iterdir(), key=lambda p: p.name):
-        if _scenario_suffix(path) in (".yaml", ".yml", ".json"):
+        if _scenario_suffix(path) in SCENARIO_SUFFIXES:
             s = _load_scenario_file(path)
             scenarios[s.name] = s
     if _CUSTOM_SCENARIOS_DIR.exists():
         for path in sorted(_CUSTOM_SCENARIOS_DIR.glob("*")):
-            if _scenario_suffix(path) in (".yaml", ".yml", ".json"):
+            if _scenario_suffix(path) in SCENARIO_SUFFIXES:
                 s = _load_scenario_file(path)
                 scenarios[s.name] = s
     # custom is always appended last as the catch-all

src/swiss_ai_model_launch/loadtest/scenario_files.py

@@ -0,0 +1,2 @@
+YAML_SCENARIO_SUFFIXES = (".yaml", ".yml")
+SCENARIO_SUFFIXES = (*YAML_SCENARIO_SUFFIXES, ".json")