Skip to content

Commit 4d9918e

Browse files
committed
Add error handling for unknown frameworks in setup and worker commands
1 parent d7e0cf0 commit 4d9918e

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

src/swiss_ai_model_launch/assets/script.sh

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ done
4747
_sglang_setup() {
4848
FRAMEWORK_ENV_SETUP="export no_proxy=\"0.0.0.0,\$no_proxy\"; export NO_PROXY=\"0.0.0.0,\$NO_PROXY\"; export SGL_ENABLE_JIT_DEEPGEMM=\"false\""
4949
FRAMEWORK_LAUNCH="python3 -m sglang.launch_server"
50+
return
5051
}
5152

5253
_sglang_worker_cmd() {
@@ -56,13 +57,15 @@ _sglang_worker_cmd() {
5657
dist_args="--dist-init-addr ${worker_host_ip}:5757 --nnodes ${NODES_PER_WORKER} --node-rank ${local_rank}"
5758
fi
5859
FRAMEWORK_CMD="$FRAMEWORK_LAUNCH $dist_args $FRAMEWORK_ARGS"
60+
return
5961
}
6062

6163
# ── vllm ────────────────────────────────────────────────────────────────────
6264

6365
_vllm_setup() {
6466
FRAMEWORK_ENV_SETUP="export RAY_CGRAPH_get_timeout=1800; export no_proxy=\"0.0.0.0,\$no_proxy\"; export NO_PROXY=\"0.0.0.0,\$NO_PROXY\""
6567
FRAMEWORK_LAUNCH="python3 -m vllm.entrypoints.openai.api_server"
68+
return
6669
}
6770

6871
_vllm_worker_cmd() {
@@ -94,13 +97,15 @@ $FRAMEWORK_LAUNCH --distributed-executor-backend ray $FRAMEWORK_ARGS"
9497
else
9598
FRAMEWORK_CMD="$FRAMEWORK_LAUNCH $FRAMEWORK_ARGS"
9699
fi
100+
return
97101
}
98102

99103
# ── main ────────────────────────────────────────────────────────────────────
100104

101105
case "$FRAMEWORK" in
102106
sglang) _sglang_setup ;;
103107
vllm) _vllm_setup ;;
108+
*) echo "Error: Unknown framework: $FRAMEWORK" >&2; exit 1 ;;
104109
esac
105110

106111
EXPECTED_NODES=$((WORKERS * NODES_PER_WORKER))
@@ -141,6 +146,7 @@ for ((worker_id=0; worker_id<WORKERS; worker_id++)); do
141146
case "$FRAMEWORK" in
142147
sglang) _sglang_worker_cmd "$local_rank" "$worker_host_ip" ;;
143148
vllm) _vllm_worker_cmd "$local_rank" "$worker_host_ip" ;;
149+
*) echo "Error: Unknown framework: $FRAMEWORK" >&2; exit 1 ;;
144150
esac
145151

146152
if [[ "$USE_OCF" = "true" ]] && [[ "$local_rank" -eq 0 ]]; then

0 commit comments

Comments
 (0)