Skip to content

Commit 396084d

Browse files
committed
Fixed incorrect dependencies errors
1 parent 3da1c66 commit 396084d

File tree

2 files changed

+3
-28
lines changed

2 files changed

+3
-28
lines changed

Block/Widgets/SideReview.php

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,27 +14,21 @@ class SideReview extends \Magento\Framework\View\Element\Template
1414
* Default template to use for review widget
1515
*/
1616
const DEFAULT_REVIEW_TEMPLATE = 'widgets/sidereview.phtml';
17-
/**
18-
* @var \Magento\Framework\App\Config\ScopeConfigInterface
19-
*/
20-
protected $scopeConfig;
17+
2118
/**
2219
* Construct
2320
*
2421
* @param \Magento\Framework\View\Element\Template\Context $context
2522
* @param \Swissup\Testimonials\Model\ResourceModel\Data\CollectionFactory $testimonialsCollectionFactory
26-
* @param \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig
2723
* @param array $data
2824
*/
2925
public function __construct(
3026
\Magento\Framework\View\Element\Template\Context $context,
3127
\Swissup\Testimonials\Model\ResourceModel\Data\CollectionFactory $testimonialsCollectionFactory,
32-
\Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig,
3328
array $data = []
3429
) {
3530
parent::__construct($context, $data);
3631
$this->_testimonialsCollectionFactory = $testimonialsCollectionFactory;
37-
$this->scopeConfig = $scopeConfig;
3832
}
3933

4034
public function _construct()
@@ -67,7 +61,7 @@ public function getListUrl()
6761
}
6862
public function getStoreName()
6963
{
70-
$storeName = $this->scopeConfig->getValue(
64+
$storeName = $this->_scopeConfig->getValue(
7165
'general/store_information/name',
7266
\Magento\Store\Model\ScopeInterface::SCOPE_STORE
7367
);

Helper/Config.php

Lines changed: 1 addition & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -116,28 +116,9 @@ class Config extends AbstractHelper
116116
*/
117117
const XML_PATH_ADMIN_EMAIL_TEMPLATE = 'testimonials/email_admin/email_template';
118118

119-
/**
120-
* @var \Magento\Framework\App\Config\ScopeConfigInterface
121-
*/
122-
protected $_scopeConfig;
123-
/**
124-
* Constructor
125-
*
126-
* @param \Magento\Framework\App\Helper\Context $context
127-
* @param \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig
128-
* @SuppressWarnings(PHPMD.ExcessiveParameterList)
129-
*/
130-
public function __construct(
131-
\Magento\Framework\App\Helper\Context $context,
132-
\Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig
133-
)
134-
{
135-
parent::__construct($context);
136-
$this->_scopeConfig = $scopeConfig;
137-
}
138119
protected function _getConfig($key)
139120
{
140-
return $this->_scopeConfig->getValue($key, ScopeInterface::SCOPE_STORE);
121+
return $this->scopeConfig->getValue($key, ScopeInterface::SCOPE_STORE);
141122
}
142123
public function isAutoApprove()
143124
{

0 commit comments

Comments
 (0)