Skip to content

Commit 64d86dc

Browse files
committed
111
1 parent 38b7a82 commit 64d86dc

File tree

3 files changed

+38
-7
lines changed

3 files changed

+38
-7
lines changed

fluss-client/src/test/java/com/alibaba/fluss/client/admin/ClientToServerITCaseBase.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ protected long createTable(
9696
return admin.getTable(tablePath).get().getTableId();
9797
}
9898

99-
private static Configuration initConfig() {
99+
public static Configuration initConfig() {
100100
Configuration conf = new Configuration();
101101
conf.setInt(ConfigOptions.DEFAULT_REPLICATION_FACTOR, 3);
102102
// set a shorter interval for testing purpose
@@ -117,7 +117,7 @@ protected static LogScanner createLogScanner(Table table, int[] projectFields) {
117117
return table.getLogScanner(new LogScan().withProjectedFields(projectFields));
118118
}
119119

120-
protected static void subscribeFromBeginning(LogScanner logScanner, Table table) {
120+
public static void subscribeFromBeginning(LogScanner logScanner, Table table) {
121121
int bucketCount = getBucketCount(table);
122122
for (int i = 0; i < bucketCount; i++) {
123123
logScanner.subscribeFromBeginning(i);

fluss-client/src/test/java/com/alibaba/fluss/client/table/FlussFailServerTableITCase.java

Lines changed: 36 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,24 +16,32 @@
1616

1717
package com.alibaba.fluss.client.table;
1818

19-
import com.alibaba.fluss.client.admin.ClientToServerITCaseBase;
19+
import com.alibaba.fluss.client.Connection;
20+
import com.alibaba.fluss.client.ConnectionFactory;
21+
import com.alibaba.fluss.client.admin.Admin;
2022
import com.alibaba.fluss.client.scanner.ScanRecord;
2123
import com.alibaba.fluss.client.scanner.log.LogScan;
2224
import com.alibaba.fluss.client.scanner.log.LogScanner;
2325
import com.alibaba.fluss.client.scanner.log.ScanRecords;
2426
import com.alibaba.fluss.client.table.writer.AppendWriter;
2527
import com.alibaba.fluss.client.table.writer.UpsertWriter;
28+
import com.alibaba.fluss.config.Configuration;
2629
import com.alibaba.fluss.metadata.TablePath;
2730
import com.alibaba.fluss.row.InternalRow;
2831
import com.alibaba.fluss.row.indexed.IndexedRow;
32+
import com.alibaba.fluss.server.testutils.FlussClusterExtension;
2933

34+
import org.junit.jupiter.api.AfterEach;
3035
import org.junit.jupiter.api.BeforeEach;
3136
import org.junit.jupiter.api.Test;
37+
import org.junit.jupiter.api.extension.RegisterExtension;
3238

3339
import java.time.Duration;
3440
import java.util.ArrayList;
3541
import java.util.List;
3642

43+
import static com.alibaba.fluss.client.admin.ClientToServerITCaseBase.initConfig;
44+
import static com.alibaba.fluss.client.admin.ClientToServerITCaseBase.subscribeFromBeginning;
3745
import static com.alibaba.fluss.record.TestData.DATA1_ROW_TYPE;
3846
import static com.alibaba.fluss.record.TestData.DATA1_TABLE_INFO;
3947
import static com.alibaba.fluss.record.TestData.DATA1_TABLE_INFO_PK;
@@ -42,17 +50,41 @@
4250
import static com.alibaba.fluss.testutils.InternalRowListAssert.assertThatRows;
4351

4452
/** IT case for {@link FlussTable} in the case of one tablet server fails. */
45-
class FlussFailServerTableITCase extends ClientToServerITCaseBase {
53+
class FlussFailServerTableITCase {
54+
55+
@RegisterExtension
56+
public static final FlussClusterExtension FLUSS_CLUSTER_EXTENSION =
57+
FlussClusterExtension.builder()
58+
.setNumOfTabletServers(3)
59+
.setClusterConf(initConfig())
60+
.build();
4661

4762
private static final int SERVER = 0;
63+
private Connection conn;
64+
protected Admin admin;
4865

4966
@BeforeEach
50-
void beforeEach() throws Exception {
67+
void beforeEach() {
68+
Configuration clientConf = FLUSS_CLUSTER_EXTENSION.getClientConfig();
69+
conn = ConnectionFactory.createConnection(clientConf);
70+
admin = conn.getAdmin();
71+
5172
// since we kill and start one tablet server in each test,
5273
// we need to wait for metadata to be updated to servers
5374
FLUSS_CLUSTER_EXTENSION.waitUtilAllGatewayHasSameMetadata();
75+
}
5476

55-
super.setup();
77+
@AfterEach
78+
protected void teardown() throws Exception {
79+
if (admin != null) {
80+
admin.close();
81+
admin = null;
82+
}
83+
84+
if (conn != null) {
85+
conn.close();
86+
conn = null;
87+
}
5688
}
5789

5890
@Test

fluss-server/src/test/java/com/alibaba/fluss/server/testutils/FlussClusterExtension.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -382,7 +382,6 @@ public void waitUtilAllGatewayHasSameMetadata() {
382382
}
383383
}
384384
}
385-
LOG.info("success once !");
386385

387386
assertThat(response.hasCoordinatorServer()).isTrue();
388387
// check coordinator server node

0 commit comments

Comments
 (0)