[T-8592][IMP] partner_private_information: Private tags visibility managed by group

Author: Anxo82

partner_private_information/README.rst

@@ -22,8 +22,21 @@ Partner Private Information
 
 |badge1| |badge2| |badge3|
 
-This module allows us to add a new tab to the partners file with private
-information that only designated users can view.
+Adds a dedicated “Private Info” tab to Contacts, containing a second set
+of contact data — including phone, mobile, e‑mail, full address, and
+categories — that is only visible and exportable by authorised users.
+This allows separating general contact details from internal-use-only
+data.
+
+Key Features
+
+This module provides:
+
+- A Private Info tab on the partner form view, visible only to users
+  with the appropriate access.
+- Controlled by the group: Extra Rights / Show partner private info.
+- Access is enabled via the user form by checking the option “Show
+  partner private info”.
 
 **Table of contents**
 
@@ -44,6 +57,9 @@ Usage
 To use this module, you need to:
 
 1. In the contact's tab we find a tab called private information.
+2. Tags (partner categories) can be flagged as **Private**. When a
+   category is marked as private, it will only be available for
+   selection in the **Private Information** tab.
 
 Bug Tracker
 ===========

partner_private_information/__manifest__.py

@@ -15,5 +15,6 @@
     "data": [
         "security/partner_private_information_security.xml",
         "views/res_partner_view.xml",
+        "views/res_partner_category_views.xml",
     ],
 }

partner_private_information/models/__init__.py

@@ -2,3 +2,4 @@
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
 
 from . import res_partner
+from . import res_partner_category

partner_private_information/models/res_partner.py

@@ -1,7 +1,9 @@
 # Copyright 2024 Roger Sans <roger.sans@sygel.es>
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
+import re
 
-from odoo import api, fields, models
+from odoo import _, api, fields, models
+from odoo.exceptions import ValidationError
 
 
 class ResPartner(models.Model):
@@ -77,3 +79,47 @@ def _address_fields(self):
             "private_country_id",
         ]
         return res
+
+    @api.constrains("private_phone", "private_mobile", "private_email")
+    def _check_internal_contact_info_format(self):
+        phone_pattern = re.compile(r"^\+?[0-9\s\-]{7,20}$")
+        email_pattern = re.compile(r"^[\w\.-]+@[\w\.-]+\.\w+$")
+
+        for record in self:
+            if record.private_phone and not phone_pattern.match(record.private_phone):
+                raise ValidationError(
+                    _(
+                        "Invalid format for Private Phone. Examples: "
+                        "'+34 912 345 678', '912-345-678'."
+                    )
+                )
+            if record.private_mobile and not phone_pattern.match(record.private_mobile):
+                raise ValidationError(
+                    _(
+                        "Invalid format for Private Mobile. Examples: "
+                        "'+34 600 100 200', '601-602-603'."
+                    )
+                )
+            if record.private_email and not email_pattern.match(record.private_email):
+                raise ValidationError(
+                    _(
+                        "Invalid format for Private Email."
+                        "Example: 'john.doe@example.com'."
+                    )
+                )
+
+    @api.onchange("private_phone", "country_id", "company_id")
+    def _onchange_private_phone_validation(self):
+        if self.private_phone:
+            self.private_phone = (
+                self._phone_format(fname="private_phone", force_format="INTERNATIONAL")
+                or self.private_phone
+            )
+
+    @api.onchange("private_mobile", "country_id", "company_id")
+    def _onchange_private_mobile_validation(self):
+        if self.private_mobile:
+            self.private_mobile = (
+                self._phone_format(fname="private_mobile", force_format="INTERNATIONAL")
+                or self.private_mobile
+            )

partner_private_information/models/res_partner_category.py

@@ -0,0 +1,7 @@
+from odoo import fields, models
+
+
+class ResPartnerCategory(models.Model):
+    _inherit = "res.partner.category"
+
+    is_private = fields.Boolean(string="Private Category", default=False)

partner_private_information/readme/DESCRIPTION.md

@@ -1 +1,9 @@
-This module allows us to add a new tab to the partners file with private information that only designated users can view.
+Adds a dedicated “Private Info” tab to Contacts, containing a second set of contact data — including phone, mobile, e‑mail, full address, and categories — that is only visible and exportable by authorised users. This allows separating general contact details from internal-use-only data.
+
+Key Features
+
+This module provides:
+
+- A Private Info tab on the partner form view, visible only to users with the appropriate access.
+- Controlled by the group: Extra Rights / Show partner private info.
+- Access is enabled via the user form by checking the option “Show partner private info”.

partner_private_information/readme/USAGE.md

@@ -1,3 +1,4 @@
 To use this module, you need to:
 
-1. In the contact's tab we find a tab called private information.
+1. In the contact's tab we find a tab called private information.
+2. Tags (partner categories) can be flagged as **Private**. When a category is marked as private, it will only be available for selection in the **Private Information** tab.

partner_private_information/security/partner_private_information_security.xml

@@ -8,4 +8,19 @@
             eval="[(4, ref('base.user_root')), (4, ref('base.user_admin'))]"
         />
     </record>
+    <record id="rule_hide_private_categories" model="ir.rule">
+        <field name="name">Hide Private Categories</field>
+        <field name="model_id" ref="base.model_res_partner_category" />
+        <field name="domain_force">[('is_private', '=', False)]</field>
+        <field name="groups" eval="[(4, ref('base.group_user'))]" />
+    </record>
+    <record id="rule_show_all_categories" model="ir.rule">
+        <field name="name">Show All Categories</field>
+        <field name="model_id" ref="base.model_res_partner_category" />
+        <field
+            name="groups"
+            eval="[(4, ref('partner_private_information.group_partner_private_info'))]"
+        />
+        <field name="domain_force">[(1, '=', 1)]</field>
+    </record>
 </odoo>

partner_private_information/static/description/index.html

@@ -370,8 +370,20 @@ <h1 class="title">Partner Private Information</h1>
 !! source digest: sha256:350d438ab706b5aabc16f6a4874de7ebb9c81819627fedc573aaf77f4c6b7fe6
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
 <p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/sygel-technology/sy-partner-contact/tree/18.0/partner_private_information"><img alt="sygel-technology/sy-partner-contact" src="https://img.shields.io/badge/github-sygel--technology%2Fsy--partner--contact-lightgray.png?logo=github" /></a></p>
-<p>This module allows us to add a new tab to the partners file with private
-information that only designated users can view.</p>
+<p>Adds a dedicated “Private Info” tab to Contacts, containing a second set
+of contact data — including phone, mobile, e‑mail, full address, and
+categories — that is only visible and exportable by authorised users.
+This allows separating general contact details from internal-use-only
+data.</p>
+<p>Key Features</p>
+<p>This module provides:</p>
+<ul class="simple">
+<li>A Private Info tab on the partner form view, visible only to users
+with the appropriate access.</li>
+<li>Controlled by the group: Extra Rights / Show partner private info.</li>
+<li>Access is enabled via the user form by checking the option “Show
+partner private info”.</li>
+</ul>
 <p><strong>Table of contents</strong></p>
 <div class="contents local topic" id="contents">
 <ul class="simple">
@@ -399,6 +411,9 @@ <h1><a class="toc-backref" href="#toc-entry-2">Usage</a></h1>
 <p>To use this module, you need to:</p>
 <ol class="arabic simple">
 <li>In the contact’s tab we find a tab called private information.</li>
+<li>Tags (partner categories) can be flagged as <strong>Private</strong>. When a
+category is marked as private, it will only be available for
+selection in the <strong>Private Information</strong> tab.</li>
 </ol>
 </div>
 <div class="section" id="bug-tracker">

partner_private_information/tests/test_partner_private_information.py

@@ -1,4 +1,4 @@
-from odoo.exceptions import AccessError
+from odoo.exceptions import AccessError, ValidationError
 from odoo.tests.common import TransactionCase, new_test_user
 
 
@@ -39,8 +39,15 @@ def test_private_fields_hidden_from_unauthorized_user(self):
 
         with self.assertRaises(AccessError):
             _ = partner.private_phone
+        with self.assertRaises(AccessError):
             _ = partner.private_email
 
     def test_private_fields_default_values(self):
         self.assertFalse(self.partner.private_phone)
         self.assertFalse(self.partner.private_email)
+
+    def test_invalid_private_phone_format(self):
+        partner = self.partner.with_user(self.user_private)
+        with self.assertRaises(ValidationError):
+            partner.private_phone = "abc123"
+            partner._check_internal_contact_info_format()