Fail to change the name of a layout in spacemacs

[jia-j-chen]

Description

Unable to change the name of a layout in spacemacs.

Reproduction guide 🪲

• Start Emacs
• Start a new layout with SPC l l and name it "Test"
• Try to rename the layout with SPC l R

Observed behaviour: 👀 💔

• Receiving an error message: "funcall-interactively: Symbol’s value as variable is void: old-name"

Expected behaviour: ❤️ 😄

• Being able to change the name of the "Test" layout.

System Info 💻

• OS: gnu/linux
• Emacs: 30.2
• Spacemacs: 0.999.0
• Spacemacs branch: develop (rev. 899032e)
• Graphic display: t
• Running in daemon: nil
• Distribution: spacemacs
• Editing style: hybrid
• Completion: helm
• Layers:

(csv auto-completion better-defaults ess
     (chinese :variables chinese-enable-fcitx t chinese-fcitx-use-dbus t
              pyim-default-scheme 'microsoft-shuangpin
              chinese-enable-youdao-dict t)
     latex emacs-lisp ranger pdf git helm markdown multiple-cursors
     (org :variables org-startup-indented t org-indent-mode t)
     (shell :variables shell-default-height 30 shell-default-position 'bottom)
     spell-checking syntax-checking version-control treemacs python
     ipython-notebook (colors :variables colors-colorize-identifiers 'all)
     major-modes)

• System configuration features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB

Backtrace 🐾

Debugger entered--Lisp error: (void-variable old-name)
  persp-rename(nil)
  funcall-interactively(persp-rename nil)
  call-interactively(persp-rename)
  spacemacs/layouts-ts-rename()
  funcall-interactively(spacemacs/layouts-ts-rename)
  hydra--call-interactively-remap-maybe(spacemacs/layouts-ts-rename)
  (progn (setq this-command 'spacemacs/layouts-ts-rename) (hydra--call-interactively-remap-maybe #'spacemacs/layouts-ts-rename))
  spacemacs/layouts-transient-state/spacemacs/layouts-ts-rename-and-exit()
  funcall-interactively(spacemacs/layouts-transient-state/spacemacs/layouts-ts-rename-and-exit)
  call-interactively(spacemacs/layouts-transient-state/spacemacs/layouts-ts-rename-and-exit nil nil)
  command-execute(spacemacs/layouts-transient-state/spacemacs/layouts-ts-rename-and-exit)

[sunlin7]

Upstream issue: Bad-ptr/persp-mode.el#156