Merge pull request #440 from tri-adam/golangci-lint-2.8

chore: bump golangci-lint to v2.8

Author: tri-adam

.circleci/config.yml

@@ -9,7 +9,7 @@ executors:
       - image: node:22-slim
   golangci-lint:
     docker:
-      - image: golangci/golangci-lint:v2.4
+      - image: golangci/golangci-lint:v2.8
   golang-previous:
     docker:
       - image: golang:1.24

pkg/integrity/sign_test.go

@@ -1,4 +1,4 @@
-// Copyright (c) 2020-2025, Sylabs Inc. All rights reserved.
+// Copyright (c) 2020-2026, Sylabs Inc. All rights reserved.
 // This software is licensed under a 3-clause BSD license. Please consult the LICENSE.md file
 // distributed with the sources of this project regarding your rights to use or distribute this
 // software.
@@ -77,7 +77,7 @@ func TestOptSignGroupObjects(t *testing.T) {
 			}
 
 			if err == nil {
-				var got []uint32
+				got := make([]uint32, 0, len(gs.ods))
 				for _, od := range gs.ods {
 					got = append(got, od.ID())
 				}
@@ -557,7 +557,7 @@ func TestNewSigner(t *testing.T) {
 					if want, ok := tt.wantGroupObjects[groupID]; !ok {
 						t.Errorf("unexpected signer for group ID %v", groupID)
 					} else {
-						var got []uint32
+						got := make([]uint32, 0, len(signer.ods))
 						for _, od := range signer.ods {
 							got = append(got, od.ID())
 						}

pkg/integrity/verify_test.go

@@ -1,4 +1,4 @@
-// Copyright (c) 2020-2025, Sylabs Inc. All rights reserved.
+// Copyright (c) 2020-2026, Sylabs Inc. All rights reserved.
 // This software is licensed under a 3-clause BSD license. Please consult the LICENSE.md file
 // distributed with the sources of this project regarding your rights to use or distribute this
 // software.
@@ -729,7 +729,8 @@ func getSignedDummy(t *testing.T, fps ...[]byte) *sif.FileImage {
 		t.Fatal(err)
 	}
 
-	dis := []sif.DescriptorInput{di}
+	dis := make([]sif.DescriptorInput, 0, 1+len(fps))
+	dis = append(dis, di)
 
 	for _, fp := range fps {
 		di, err := sif.NewDescriptorInput(sif.DataSignature, strings.NewReader("sig"),

pkg/siftool/add_test.go

@@ -1,4 +1,4 @@
-// Copyright (c) 2021-2023, Sylabs Inc. All rights reserved.
+// Copyright (c) 2021-2026, Sylabs Inc. All rights reserved.
 // This software is licensed under a 3-clause BSD license. Please consult the
 // LICENSE file distributed with the sources of this project regarding your
 // rights to use or distribute this software.
@@ -52,10 +52,11 @@ func Test_command_getAdd(t *testing.T) {
 
 			cmd := c.getAdd()
 
-			args := []string{
+			args := make([]string, 0, 2+len(tt.flags))
+			args = append(args,
 				makeTestSIF(t, false),
 				filepath.Join("testdata", "input", "input.bin"),
-			}
+			)
 			args = append(args, tt.flags...)
 
 			runCommand(t, cmd, args, nil)