mv --backup=simple a b on hard links should not fail

touch a
ln a b
./target/debug/coreutils mv --backup=simple a b

GNU: tests/mv/hard-4.sh

Author: sylvestre

src/uu/mv/src/mv.rs

@@ -250,12 +250,16 @@ fn handle_two_paths(source: &Path, target: &Path, b: &Behavior) -> UResult<()> {
     }
 
     if source.eq(target) || is_hardlink(source, target) {
-        if source.eq(Path::new(".")) || source.ends_with("/.") || source.is_file() {
-            return Err(
-                MvError::SameFile(source.quote().to_string(), target.quote().to_string()).into(),
-            );
-        } else {
-            return Err(MvError::SelfSubdirectory(source.display().to_string()).into());
+        if b.backup != BackupMode::SimpleBackup {
+            if source.eq(Path::new(".")) || source.ends_with("/.") || source.is_file() {
+                return Err(MvError::SameFile(
+                    source.quote().to_string(),
+                    target.quote().to_string(),
+                )
+                .into());
+            } else {
+                return Err(MvError::SelfSubdirectory(source.display().to_string()).into());
+            }
         }
     }
 

tests/by-util/test_mv.rs

@@ -382,6 +382,23 @@ fn test_mv_same_hardlink() {
         .stderr_is(format!("mv: '{file_a}' and '{file_b}' are the same file\n",));
 }
 
+#[test]
+#[cfg(unix)]
+fn test_mv_same_hardlink_backup_simple() {
+    let (at, mut ucmd) = at_and_ucmd!();
+    let file_a = "test_mv_same_file_a";
+    let file_b = "test_mv_same_file_b";
+    at.touch(file_a);
+
+    at.hard_link(file_a, file_b);
+
+    at.touch(file_a);
+    ucmd.arg(file_a)
+        .arg(file_b)
+        .arg("--backup=simple")
+        .succeeds();
+}
+
 #[test]
 fn test_mv_same_file_not_dot_dir() {
     let (at, mut ucmd) = at_and_ucmd!();