ls: fix Windows compilation by properly handling platform-specific code

- Group Unix-only mode constants in a module with single cfg attribute
- Split platform-specific functions for file/directory/special file indicators
- Unix versions take path parameters for metadata access
- Windows versions use same signatures but prefix unused params with underscore
- This eliminates unused variable and dead code warnings on Windows
  while maintaining full functionality on Unix platforms

Author: sylvestre

src/uu/ls/src/colors.rs

@@ -19,13 +19,19 @@ const ANSI_RESET: &str = "\x1b[0m";
 const ANSI_CLEAR_EOL: &str = "\x1b[K";
 const EMPTY_STYLE: &str = "\x1b[m";
 
-// Unix file mode bits
-const MODE_SETUID: u32 = 0o4000;
-const MODE_SETGID: u32 = 0o2000;
-const MODE_EXECUTABLE: u32 = 0o0111;
-const MODE_STICKY_OTHER_WRITABLE: u32 = 0o1002;
-const MODE_OTHER_WRITABLE: u32 = 0o0002;
-const MODE_STICKY: u32 = 0o1000;
+#[cfg(unix)]
+mod unix_mode_bits {
+    // Unix file mode bits
+    pub const MODE_SETUID: u32 = 0o4000;
+    pub const MODE_SETGID: u32 = 0o2000;
+    pub const MODE_EXECUTABLE: u32 = 0o0111;
+    pub const MODE_STICKY_OTHER_WRITABLE: u32 = 0o1002;
+    pub const MODE_OTHER_WRITABLE: u32 = 0o0002;
+    pub const MODE_STICKY: u32 = 0o1000;
+}
+
+#[cfg(unix)]
+use unix_mode_bits::*;
 
 enum RawIndicatorStyle {
     Empty,
@@ -403,8 +409,8 @@ impl<'a> StyleManager<'a> {
         None
     }
 
+    #[cfg(unix)]
     fn indicator_for_file(&self, path: &PathData) -> Option<Indicator> {
-        #[cfg(unix)]
         if self.needs_file_metadata() {
             if let Some(metadata) = path.metadata() {
                 let mode = metadata.mode();
@@ -432,8 +438,17 @@ impl<'a> StyleManager<'a> {
         }
     }
 
+    #[cfg(not(unix))]
+    fn indicator_for_file(&self, _path: &PathData) -> Option<Indicator> {
+        if self.has_indicator_style(Indicator::RegularFile) {
+            Some(Indicator::RegularFile)
+        } else {
+            None
+        }
+    }
+
+    #[cfg(unix)]
     fn indicator_for_directory(&self, path: &PathData) -> Option<Indicator> {
-        #[cfg(unix)]
         if self.needs_dir_metadata() {
             if let Some(metadata) = path.metadata() {
                 let mode = metadata.mode();
@@ -460,22 +475,34 @@ impl<'a> StyleManager<'a> {
         }
     }
 
+    #[cfg(not(unix))]
+    fn indicator_for_directory(&self, _path: &PathData) -> Option<Indicator> {
+        if self.has_indicator_style(Indicator::Directory) {
+            Some(Indicator::Directory)
+        } else {
+            None
+        }
+    }
+
+    #[cfg(unix)]
     fn indicator_for_special_file(&self, file_type: &std::fs::FileType) -> Option<Indicator> {
-        #[cfg(unix)]
-        {
-            if file_type.is_fifo() && self.has_indicator_style(Indicator::FIFO) {
-                return Some(Indicator::FIFO);
-            }
-            if file_type.is_socket() && self.has_indicator_style(Indicator::Socket) {
-                return Some(Indicator::Socket);
-            }
-            if file_type.is_block_device() && self.has_indicator_style(Indicator::BlockDevice) {
-                return Some(Indicator::BlockDevice);
-            }
-            if file_type.is_char_device() && self.has_indicator_style(Indicator::CharacterDevice) {
-                return Some(Indicator::CharacterDevice);
-            }
+        if file_type.is_fifo() && self.has_indicator_style(Indicator::FIFO) {
+            return Some(Indicator::FIFO);
+        }
+        if file_type.is_socket() && self.has_indicator_style(Indicator::Socket) {
+            return Some(Indicator::Socket);
+        }
+        if file_type.is_block_device() && self.has_indicator_style(Indicator::BlockDevice) {
+            return Some(Indicator::BlockDevice);
         }
+        if file_type.is_char_device() && self.has_indicator_style(Indicator::CharacterDevice) {
+            return Some(Indicator::CharacterDevice);
+        }
+        None
+    }
+
+    #[cfg(not(unix))]
+    fn indicator_for_special_file(&self, _file_type: &std::fs::FileType) -> Option<Indicator> {
         None
     }