remove i18n as feature

Author: sylvestre

.github/workflows/l10n.yml

@@ -33,9 +33,9 @@ jobs:
       fail-fast: false
       matrix:
         job:
-          - { os: ubuntu-latest  , features: "feat_os_unix,i18n" }
-          - { os: macos-latest   , features: "feat_os_macos,i18n" }
-          - { os: windows-latest , features: "feat_os_windows,i18n" }
+          - { os: ubuntu-latest  , features: "feat_os_unix" }
+          - { os: macos-latest   , features: "feat_os_macos" }
+          - { os: windows-latest , features: "feat_os_windows" }
     steps:
     - uses: actions/checkout@v4
       with:
@@ -68,8 +68,8 @@ jobs:
       shell: bash
       run: |
         ## Test l10n functionality
-        cargo test --features i18n -p uucore locale
-        cargo test --features i18n
+        cargo test -p uucore locale
+        cargo test
       env:
         RUST_BACKTRACE: "1"
 
@@ -203,18 +203,12 @@ jobs:
       run: |
         ## Test different l10n feature combinations
 
-        echo "Testing with i18n feature enabled..."
-        cargo check --features "i18n" -p uucore
-
-        echo "Testing with i18n feature disabled (no feature flag)..."
+        echo "Testing with i18n enabled by default..."
         cargo check -p uucore
 
         echo "Testing with disable_i18n feature..."
         cargo check --features "disable_i18n" -p uucore
 
-        echo "Testing conflicting features (should work, disable_i18n takes precedence)..."
-        cargo check --features "i18n,disable_i18n" -p uucore
-
         echo "All feature combinations compiled successfully"
       env:
         RUST_BACKTRACE: "1"

Cargo.toml

@@ -65,8 +65,6 @@ feat_selinux = [
 # * All utilities will use hardcoded English strings regardless of system locale
 # * Automatically disables uucore's default i18n feature
 disable_i18n = ["uucore/disable_i18n"]
-# i18n support (enabled by default via uucore)
-i18n = ["uucore/i18n"]
 ##
 ## feature sets
 ## (common/core and Tier1) feature sets

src/bin/coreutils.rs

@@ -83,7 +83,7 @@ fn find_prefixed_util<'a>(
 fn setup_localization_or_exit(util_name: &str) {
     locale::setup_localization(get_canonical_util_name(util_name)).unwrap_or_else(|err| {
         match err {
-            #[cfg(all(feature = "i18n", not(feature = "disable_i18n")))]
+            #[cfg(not(feature = "disable_i18n"))]
             uucore::locale::LocalizationError::ParseResource {
                 error: err_msg,
                 snippet,

src/uucore/Cargo.toml

@@ -101,9 +101,7 @@ windows-sys = { workspace = true, optional = true, default-features = false, fea
 utmp-classic = { workspace = true, optional = true }
 
 [features]
-default = ["i18n"]
-# i18n support (enabled by default, disabled when disable_i18n is used)
-i18n = ["fluent-bundle", "fluent", "fluent-syntax", "unic-langid"]
+default = []
 # disable_i18n disables translations and embeds English strings directly
 disable_i18n = []
 # * non-default features

src/uucore/src/lib/lib.rs

@@ -184,7 +184,7 @@ macro_rules! bin {
             )))
             .unwrap_or_else(|err| {
                 match err {
-                    #[cfg(all(feature = "i18n", not(feature = "disable_i18n")))]
+                    #[cfg(not(feature = "disable_i18n"))]
                     uucore::locale::LocalizationError::ParseResource {
                         error: err_msg,
                         snippet,