Simplify code for validator pass test

dbu · dbu · commit 64cfaeff153a · 2018-01-23T08:19:43.000+01:00
diff --git a/tests/Unit/DependencyInjection/Compiler/ValidationPassTest.php b/tests/Unit/DependencyInjection/Compiler/ValidationPassTest.php
@@ -50,12 +50,10 @@ public function testRegisterDocumentsValidation($hasPhpcr, $hasValidator, $shoul
                 'addXmlMappings',
                 [["{$dir}/../../Resources/config/validation-phpcr.xml"]]
             );
-        } else {
-            if ($hasValidator) {
-                $definition = $this->container->findDefinition('validator.builder');
+        } elseif ($hasValidator) {
+            $definition = $this->container->findDefinition('validator.builder');
 
-                $this->assertFalse($definition->hasMethodCall('addXmlMappings'));
-            }
+            $this->assertFalse($definition->hasMethodCall('addXmlMappings'));
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -50,12 +50,10 @@ public function testRegisterDocumentsValidation($hasPhpcr, $hasValidator, $shoul`
`50`	`50`	`'addXmlMappings',`
`51`	`51`	`[["{$dir}/../../Resources/config/validation-phpcr.xml"]]`
`52`	`52`	`);`
`53`		`- } else {`
`54`		`- if ($hasValidator) {`
`55`		`- $definition = $this->container->findDefinition('validator.builder');`
	`53`	`+ } elseif ($hasValidator) {`
	`54`	`+ $definition = $this->container->findDefinition('validator.builder');`
`56`	`55`
`57`		`- $this->assertFalse($definition->hasMethodCall('addXmlMappings'));`
`58`		`- }`
	`56`	`+ $this->assertFalse($definition->hasMethodCall('addXmlMappings'));`
`59`	`57`	`}`
`60`	`58`	`}`
`61`	`59`