Use data providers

Author: OskarStark

tests/Service/LabelNameExtractorTest.php

@@ -10,16 +10,25 @@
 
 class LabelNameExtractorTest extends TestCase
 {
-    public function testExtractLabels()
+    /**
+     * @dataProvider provideLabels
+     */
+    public function testExtractLabels(array $expected, string $title)
     {
         $api = new StaticLabelApi();
         $extractor = new LabelNameExtractor($api, new NullLogger());
         $repo = new Repository('carsonbot-playground', 'symfony');
 
-        $this->assertSame(['Messenger'], $extractor->extractLabels('[Messenger] Foobar', $repo));
-        $this->assertSame(['Messenger'], $extractor->extractLabels('[messenger] Foobar', $repo));
-        $this->assertSame(['Messenger', 'Mime'], $extractor->extractLabels('[Messenger][Mime] Foobar', $repo));
-        $this->assertSame(['Messenger', 'Mime'], $extractor->extractLabels('[Messenger] [Mime] Foobar', $repo));
-        $this->assertSame(['Messenger', 'Mime'], $extractor->extractLabels('[Messenger] Foobar [Mime] ', $repo));
+        $this->assertSame($expected, $extractor->extractLabels($title, $repo));
+    }
+
+    public static function provideLabels(): iterable
+    {
+        yield [['Messenger'], '[Messenger] Foobar'];
+        yield [['Messenger'], '[messenger] Foobar'];
+        yield [['Messenger', 'Mime'], '[Messenger][Mime] Foobar'];
+        yield [['Messenger', 'Mime'], '[Messenger] [Mime] Foobar'];
+        yield [['Messenger', 'Mime'], '[Messenger] Foobar [Mime]'];
+
     }
 }

tests/Service/WipParserTest.php

@@ -9,15 +9,23 @@
 
 class WipParserTest extends TestCase
 {
-    public function testMatchTitle()
+    /**
+     * @dataProvider titlesProvider
+     */
+    public function testMatchTitle(bool $expected, string $title)
     {
-        $this->assertTrue(WipParser::matchTitle('[WIP] foo'));
-        $this->assertTrue(WipParser::matchTitle('WIP: bar'));
-        $this->assertTrue(WipParser::matchTitle('(WIP) xas'));
-        $this->assertTrue(WipParser::matchTitle('[WIP]foo'));
-        $this->assertTrue(WipParser::matchTitle('[wip] foo'));
+        $this->assertSame($expected, WipParser::matchTitle($title));
+    }
+
+    public static function titlesProvider(): iterable
+    {
+        yield [true, '[WIP] foo'];
+        yield [true, 'WIP: bar'];
+        yield [true, '(WIP) xas'];
+        yield [true, '[WIP]foo'];
+        yield [true, '[wip] foo'];
 
-        $this->assertFalse(WipParser::matchTitle('Bar [WIP] foo'));
-        $this->assertFalse(WipParser::matchTitle('FOOWIP: foo'));
+        yield [false, 'Bar [WIP] foo'];
+        yield [false, 'FOOWIP: foo'];
     }
 }