Commit 75746d6
committed
feature #1504 [Store][Postgres] Implement remove() method (chr-hertel)
This PR was merged into the main branch.
Discussion
----------
[Store][Postgres] Implement remove() method
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | yes
| Docs? | no
| Issues | Fix #1483
| License | MIT
Implements the `remove()` method for the Postgres store, following the pattern from the Pinecone implementation.
## Changes Made
**Implementation** (`src/store/src/Bridge/Postgres/Store.php`):
- Added `remove(string|array $ids, array $options = []): void` method
- Accepts both single ID (string) and multiple IDs (array)
- Handles empty arrays gracefully with early return
- Uses PDO prepared statements with parameterized queries for SQL injection protection
- Executes `DELETE FROM table WHERE id IN (?, ?, ...)` queries
**Tests** (`src/store/src/Bridge/Postgres/Tests/StoreTest.php`):
- `testRemoveSingleDocument()` - verifies removal of a single document by string ID
- `testRemoveMultipleDocuments()` - verifies removal of multiple documents with proper parameter binding
- `testRemoveWithEmptyArray()` - ensures no database calls are made for empty arrays
**Configuration**:
- Added `.gitignore` in store directory to exclude test cache files
## Testing
- ✅ Code review completed - no issues found
- ✅ Security scan completed - no vulnerabilities detected
- ✅ Syntax validation passed
- ✅ Implementation follows existing code patterns and Symfony coding standards
The implementation is ready for CI testing.
---
✨ Let Copilot coding agent <a href="https://github.com/symfony/ai/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot">set things up for you</a> — coding agent works faster and does higher quality work when set up for your repo.
<!-- START COPILOT CODING AGENT TIPS -->
---
✨ Let Copilot coding agent [set things up for you](https://github.com/symfony/ai/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo.
Commits
-------
ea23f93 Implement remove() method for Postgres Store2 files changed
+94
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
21 | 20 | | |
22 | 21 | | |
23 | 22 | | |
| |||
131 | 130 | | |
132 | 131 | | |
133 | 132 | | |
134 | | - | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
135 | 151 | | |
136 | 152 | | |
137 | 153 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
688 | 688 | | |
689 | 689 | | |
690 | 690 | | |
| 691 | + | |
| 692 | + | |
| 693 | + | |
| 694 | + | |
| 695 | + | |
| 696 | + | |
| 697 | + | |
| 698 | + | |
| 699 | + | |
| 700 | + | |
| 701 | + | |
| 702 | + | |
| 703 | + | |
| 704 | + | |
| 705 | + | |
| 706 | + | |
| 707 | + | |
| 708 | + | |
| 709 | + | |
| 710 | + | |
| 711 | + | |
| 712 | + | |
| 713 | + | |
| 714 | + | |
| 715 | + | |
| 716 | + | |
| 717 | + | |
| 718 | + | |
| 719 | + | |
| 720 | + | |
| 721 | + | |
| 722 | + | |
| 723 | + | |
| 724 | + | |
| 725 | + | |
| 726 | + | |
| 727 | + | |
| 728 | + | |
| 729 | + | |
| 730 | + | |
| 731 | + | |
| 732 | + | |
| 733 | + | |
| 734 | + | |
| 735 | + | |
| 736 | + | |
| 737 | + | |
| 738 | + | |
| 739 | + | |
| 740 | + | |
| 741 | + | |
| 742 | + | |
| 743 | + | |
| 744 | + | |
| 745 | + | |
| 746 | + | |
| 747 | + | |
| 748 | + | |
| 749 | + | |
| 750 | + | |
| 751 | + | |
| 752 | + | |
| 753 | + | |
| 754 | + | |
| 755 | + | |
| 756 | + | |
| 757 | + | |
| 758 | + | |
| 759 | + | |
| 760 | + | |
| 761 | + | |
| 762 | + | |
| 763 | + | |
| 764 | + | |
| 765 | + | |
| 766 | + | |
691 | 767 | | |
692 | 768 | | |
693 | 769 | | |
| |||
0 commit comments